Shouldn't display error between the time commits are autolanded and when the results are available

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mcote, Assigned: mdoglio)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
There's a brief period between when autoland has landed the commits on Try (or presumably other branches) and when results are available from Treeherder.  During this time you get

Commit(s) successfully landed on try
Error fetching the results for <revision> on try from Treeherder
Revision not found

There should be a special state here, with some sort of reasonable timeout, during which time something like "Waiting for results to be available on Treeherder for <revision> on try" is displayed.
(Assignee)

Comment 1

3 years ago
Created attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

mozreview: better message when push not found on treeherder (bug 1230576); r?mcote
Attachment #8698458 - Flags: review?(mcote)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28009/diff/1-2/
(Reporter)

Updated

3 years ago
Attachment #8698458 - Flags: review?(mcote)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

https://reviewboard.mozilla.org/r/28009/#review25071

::: pylib/mozreview/mozreview/static/mozreview/js/autoland.js:292
(Diff revision 1)
> -          $(actionMeta).text('Revision not found');
> +        $(actionHeading).text('Waiting for Treeherder to fetch the new info');

This is a little clumsy... maybe "Waiting for revision to appear in Treeherder"?

::: pylib/mozreview/mozreview/static/mozreview/js/autoland.js:294
(Diff revision 1)
> +      }else if (response.results.length > 1) {

Missing space after }.
(Assignee)

Comment 4

3 years ago
Comment on attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28009/diff/1-2/
Attachment #8698458 - Flags: review?(mcote)
(Reporter)

Updated

3 years ago
Attachment #8698458 - Flags: review?(mcote) → review+
(Reporter)

Comment 5

3 years ago
Comment on attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

https://reviewboard.mozilla.org/r/28009/#review25097
(Assignee)

Updated

3 years ago
Assignee: nobody → mdoglio
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.