1230577 - Short UI hang on address-bar focus on first-launch

Status: RESOLVED WORKSFORME

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Build 3c09c504c45ec2821a819812e3611abed8a5b202
Launch
Skip the tour
Touch the address bar

* UI hang for a few seconds *

This is only on first-launch. I can't reproduce afterwards on new launches.

2015-12-04 11:18:22.459 [Debug] [BrowserViewController.swift:387] viewDidLayoutSubviews() > BVC done.

-----

2015-12-04 11:18:27.774 [Debug] [BrowserViewController.swift:381] viewDidLayoutSubviews() > BVC viewDidLayoutSubviews…

Comment 1

[Richard Newman [:rnewman]]

Shouldn't be related to Sync: no account set up (which will be the case if you skipped the tour) means we'll short-circuit, and you should see a warning in the log.


        private func withSyncInputs<T>(label: EngineIdentifier? = nil, function: (SyncDelegate, Prefs, Ready) -> Deferred<Maybe<T>>) -> Deferred<Maybe<T>>? {
            if let account = profile.account {
                …
            }

            log.warning("No account; can't sync.")
            return nil

Comment 2

[Richard Newman [:rnewman]]

Per IRC doesn't affect v1.3, which also implies that it's not related to sync scheduling. (The code for that is the same on both branches.)

Comment 3

[Richard Newman [:rnewman]]

I can't repro this pause on current master.

If I hit pause in Xcode immediately after tapping the URL bar, I see main-thread [CPBitmapStore openAndMmap:withInfo:] being called from UIApplicationMain, but no real slowdown.

Comment 4

[Aaron Train [:aaronmt]]

When I hit pause during the hang on my iPhone 6, it breaks on frame 21:

  * frame #21: 0x000000018804b814 UIKit`-[UITextField becomeFirstResponder] + 64
  * frame #22: 0x0000000100117860 Client`Client.URLBarView.(self=0x000000013fe38050) -> (Swift.Optional<Swift.String>, pasted : Swift.Bool) -> ()).(closure #2) + 148 at URLBarView.swift:480

Comment 5

[Aaron Train [:aaronmt]]

NI to see if this still happens