Closed
Bug 123059
Opened 23 years ago
Closed 23 years ago
Can't get handle to doc's window if plugin is HIDDEN (no view)
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: TaylorToddK, Assigned: peterlubczynski-bugs)
Details
Attachments
(1 file)
2.32 KB,
patch
|
peterlubczynski-bugs
:
review+
beard
:
superreview+
|
Details | Diff | Splinter Review |
Hidden windows need some ability to access a window handle to the browser, for cases where they need to present ui in the form of a dialog or msgbox. Without this, a dialog created will not be able to be "attached" to the browser window it is related to.
Assignee | ||
Comment 1•23 years ago
|
||
To expand on this: You can get the handle to the document's window by calling NPN_GetValue and asking for the nsPluginInstancePeerVariable_NetscapeWindow. The problem is that the method of getting the handle from the widget requires a view. Plugins that have a HIDDEN attribute, don't have a view, so this fails. :( This is blocking embedding from working on their Default Plugin. Attaching a patch that takes a better route throug the pres shell.
Severity: normal → blocker
Status: NEW → ASSIGNED
Keywords: edt0.9.4
OS: Windows 2000 → All
Priority: -- → P1
Summary: Hidden plug-in problem → Can't get handle to doc's window if plugin is HIDDEN (no view)
Target Milestone: --- → mozilla0.9.9
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Summary: Can't get handle to doc's window if plugin is HIDDEN (no view) → Can't get handel to doc's window if plugin is HIDDEN (no view)
Assignee | ||
Updated•23 years ago
|
Summary: Can't get handel to doc's window if plugin is HIDDEN (no view) → Can't get handle to doc's window if plugin is HIDDEN (no view)
Reporter | ||
Comment 3•23 years ago
|
||
r=ToddTaylor Tested the patch, looks good. Was able to retrieve the window handle for the "parent" when the plug-in was hidden.
Comment 4•23 years ago
|
||
Comment on attachment 67500 [details] [diff] [review] patch v.1 sr=beard
Attachment #67500 -
Flags: superreview+
Assignee | ||
Comment 5•23 years ago
|
||
Patch in trunk
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 6•23 years ago
|
||
sorry to nit here, but, can you remove the added line break and add back the removed one at the bottom of this patch. if we're going to have to do patch shuffling, any added/removed whitespace can wreak havoc w/ a merge. with that, please drive into 0.9.4 branch and add fixed0.9.4 to the keyword field. any trunk patch here?
Comment 7•23 years ago
|
||
bugs moving to fast for me. I see this is in the trunk; my bad.
Assignee | ||
Comment 8•23 years ago
|
||
Same patch should work for both as that code hasn't changed in a while. The last hunk of this patch is simply removing some whitspace after the bracket. I'll take care with applying to the 0.9.4 branch.
Assignee | ||
Updated•23 years ago
|
Attachment #67500 -
Flags: review+
Comment 10•22 years ago
|
||
verif patch is in brnch/trunk.
Status: RESOLVED → VERIFIED
Keywords: verified0.9.4
Keywords: fixed0.9.4
Comment hidden (off-topic) |
Comment hidden (off-topic) |
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•