Closed
Bug 1230603
Opened 9 years ago
Closed 9 years ago
"Clear private data on exit" checkbox state not saved
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox42 unaffected, firefox43 unaffected, firefox44 unaffected, firefox45 verified, fennec45+)
VERIFIED
FIXED
Firefox 45
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | unaffected |
| firefox43 | --- | unaffected |
| firefox44 | --- | unaffected |
| firefox45 | --- | verified |
| fennec | 45+ | --- |
People
(Reporter: u421692, Assigned: sebastian)
Details
(Keywords: regression)
Attachments
(1 file)
Steps to reproduce: 1. Open Settings->Privacy->Clear private data on exit 2. Selct data to clear and tap the "SET" button 3. Go back to previous menu 4. Open Privacy sub-menu Expected result: Checkbox is checked Actual result: Checkbox is not checked (user still has the Quit button, and "Clear private data on exit" feature enabled Logs: https://pastebin.mozilla.org/8853858
Potentially related to bug 1226130 (based on when it was fixed and what versions it affects)? Sebastian, do you think this could be related?
tracking-fennec: --- → ?
Flags: needinfo?(s.kaspari)
|
Assignee | |
Comment 2•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #1) > Sebastian, do you think this could be related? Yes, this looks like a regression I introduced.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Bug 1230603 - GeckoPreferences: Always process matching PrefHandlers. r?margaret
Attachment #8697250 -
Flags: review?(margaret.leibovic)
|
|
Assignee | |
Comment 4•9 years ago
|
||
My assumption from bug 1226130 was wrong: The PrefHandlers should always run; They setup preferences or hide them. Moving them to the end of the long if/else chain means they never run because we exit in some previous if statement.
|
||
Updated•9 years ago
|
Attachment #8697250 -
Flags: review?(margaret.leibovic) → review+
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8697250 [details] MozReview Request: Bug 1230603 - GeckoPreferences: Always process matching PrefHandlers. r?margaret https://reviewboard.mozilla.org/r/27531/#review24801
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2ecbe51f7675382e6dee0634299800ec027ca327 Bug 1230603 - GeckoPreferences: Always process matching PrefHandlers. r=margaret
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2ecbe51f7675
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Verified fixed on latest Nightly on Samsung Galaxy Note 3 (Android 4.4.2)
Status: RESOLVED → VERIFIED
|
|
||
Updated•9 years ago
|
tracking-fennec: ? → 45+
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•