1230660 - 5,400 warnings emitted from nsContentIterator

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Eric Rahm [:erahm]]

This is a regression from bug 1218032. There are 3 new verbose warnings, details below.

> 1905 [NNNNN] WARNING: '!mFirst', file dom/base/nsContentIterator.cpp, line 488

This warning [1] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm51-tests1-linux64-build10.txt:1553
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm121-tests1-linux64-build4.txt:60
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-7-bm114-tests1-linux64-build4.txt:58
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-7-bm121-tests1-linux64-build13.txt:58
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm121-tests1-linux64-build1.txt:58
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm117-tests1-linux64-build0.txt:45
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm67-tests1-linux64-build9.txt:34
> mozilla-central_ubuntu64_vm-debug_test-crashtest-e10s-bm51-tests1-linux64-build22.txt:17
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm67-tests1-linux64-build10.txt:11
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-6-bm114-tests1-linux64-build12.txt:9
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-7-bm117-tests1-linux64-build9.txt:2

It shows up in 34 tests. A few of the most prevalent:

> 1406 - editor/libeditor/tests/test_bug772796.html
> 116 - /selection/addRange.html
> 116 - dom/imptests/editing/selecttest/test_addRange.html
> 45 - docshell/test/navigation/test_bug386782.html
> 31 - toolkit/content/tests/chrome/test_bug360437.xul
> 21 - editor/libeditor/tests/test_bug478725.html
> 20 - editor/libeditor/tests/test_bug611182.html
> 17 - editor/libeditor/tests/test_bug487524.html
> 15 - editor/libeditor/tests/test_bug570144.html
> 13 - editor/libeditor/tests/test_bug525389.html


> 1868 [NNNNN] WARNING: '!NodeIsInTraversalRange(mFirst, mPre, startNode, startIndx, endNode, endIndx)', file dom/base/nsContentIterator.cpp, line 409

This warning [2] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm51-tests1-linux64-build10.txt:1550
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm121-tests1-linux64-build4.txt:60
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-7-bm114-tests1-linux64-build4.txt:58
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-7-bm121-tests1-linux64-build13.txt:58
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm121-tests1-linux64-build1.txt:58
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm117-tests1-linux64-build0.txt:45
> mozilla-central_ubuntu64_vm-debug_test-crashtest-e10s-bm51-tests1-linux64-build22.txt:17
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm67-tests1-linux64-build10.txt:11
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-6-bm114-tests1-linux64-build12.txt:9
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-7-bm117-tests1-linux64-build9.txt:2

It shows up in 32 tests. A few of the most prevalent:

> 1406 - editor/libeditor/tests/test_bug772796.html
> 116 - /selection/addRange.html
> 116 - dom/imptests/editing/selecttest/test_addRange.html
> 45 - docshell/test/navigation/test_bug386782.html
> 21 - editor/libeditor/tests/test_bug478725.html
> 20 - editor/libeditor/tests/test_bug611182.html
> 17 - editor/libeditor/tests/test_bug487524.html
> 15 - editor/libeditor/tests/test_bug570144.html
> 13 - editor/libeditor/tests/test_bug525389.html
> 12 - editor/libeditor/tests/test_bug414526.html


> 1635 [NNNNN] WARNING: '!NodeIsInTraversalRange(mLast, mPre, startNode, startIndx, endNode, endIndx)', file dom/base/nsContentIterator.cpp, line 453

This warning [3] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm51-tests1-linux64-build10.txt:1549
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm117-tests1-linux64-build0.txt:45
> mozilla-central_ubuntu64_vm-debug_test-crashtest-e10s-bm51-tests1-linux64-build22.txt:17
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm67-tests1-linux64-build10.txt:11
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-6-bm114-tests1-linux64-build12.txt:9
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-7-bm117-tests1-linux64-build9.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm121-tests1-linux64-build4.txt:2

It shows up in 29 tests. A few of the most prevalent:

> 1406 - editor/libeditor/tests/test_bug772796.html
> 45 - docshell/test/navigation/test_bug386782.html
> 21 - editor/libeditor/tests/test_bug478725.html
> 20 - editor/libeditor/tests/test_bug611182.html
> 17 - editor/libeditor/tests/test_bug487524.html
> 15 - editor/libeditor/tests/test_bug570144.html
> 13 - editor/libeditor/tests/test_bug525389.html
> 12 - editor/libeditor/tests/test_bug414526.html
> 11 - layout/generic/test/test_movement_by_characters.html
> 9 - editor/libeditor/tests/test_bug832025.html

[1] https://hg.mozilla.org/mozilla-central/annotate/cfb5851c96ea/dom/base/nsContentIterator.cpp#l488
[2] https://hg.mozilla.org/mozilla-central/annotate/cfb5851c96ea/dom/base/nsContentIterator.cpp#l409
[3] https://hg.mozilla.org/mozilla-central/annotate/cfb5851c96ea/dom/base/nsContentIterator.cpp#l453

Comment 1

[Eric Rahm [:erahm]]

Attachment: Remove verbose warnings emitted from nsContentIterator

Comment 2

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23599e1b42e185d0b15a4bf8f3bb18947abffc54
Bug 1230660 - Remove verbose warnings emitted from nsContentIterator. r=smaug

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23599e1b42e1