123070 - cvs and tinderbox/bonsai handle 1-second boundary condition differently

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The way cvs handles files checked in at the 00 second within a minute is
different from the way tinderbox and bonsai handle them.  This can cause minor
confusion for two reasons:
 * pull-by-date tinderbox builds, which are thought to have checkins exactly as
shown by tinderbox, don't do so.  (See, for example, the cvs log for revision
1.143 of mailnews/base/public/nsIMsgFolder.idl, which is how I noticed this
problem.)  This one file was pulled into a build that pulled by date at 13:46,
but neither tinderbox or bonsai showed it as such, and the build went red.  It
would have been clearer that this was midcheckin if the checkin was listed in 2
rows on tinderbox and if the bonsai query worked differently.  This probably
could be worked around by having the pull-by-date tinderboxes pull at the 59
second of the previous minute, but I think that's wrong because of the second
problem.
 * The bonsai query doesn't reflect changes between two pulls-by-date accurately
(for example, when binary-searching checkins).  For example, a bonsai query
showing all checkins between two points in time, for example,
http://bonsai.mozilla.org/cvsquery.cgi?module=MozillaTinderboxAll&date=explicit&mindate=1012599960&maxdate=1012601879
, does not perfectly reflect what would happen if one had a pull-by-date build
at the earlier time and updated it to the later time.

I admit this is minor, but I thought it's at least worth having a bug on it.

Comment 1

[Chris McAfee]

It is little things like this that I really am a strong supporter of
tinderbox redundancy.  We're not gonna be perfect, and chances that
we blow it in 2 or 3 builds all at once are pretty low.  I've tried to
run the different perf tests in at least pairs for this reason, if
some number jumps you want to see it on the other machine as well and
then you can start believing the numbers.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Tinderbox isn't maintained anymore. Closing.