Closed
Bug 1230735
Opened 8 years ago
Closed 8 years ago
about:performance addons is broken
Categories
(Toolkit :: Performance Monitoring, defect)
Toolkit
Performance Monitoring
Tracking
()
RESOLVED
WORKSFORME
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file)
Full Message: TypeError: deltaAlerts.alerts is undefined Full Stack: View.updateCategory@chrome://global/content/aboutPerformance.js:571:29 Control.update<@chrome://global/content/aboutPerformance.js:856:13 Most likely regression due to bug 1186491.
Assignee | ||
Updated•8 years ago
|
Summary: about:performance is broken → about:performance addons is broken
Assignee | ||
Comment 1•8 years ago
|
||
Bug 1230735 - AddonWatcher.alerts is now a map;r?felipe
Attachment #8698333 -
Flags: review?(felipc)
Comment 2•8 years ago
|
||
Comment on attachment 8698333 [details] MozReview Request: Bug 1230735 - AddonWatcher.alerts is now a map;r?felipe https://reviewboard.mozilla.org/r/27855/#review25481 ::: toolkit/components/aboutperformance/content/aboutPerformance.js:571 (Diff revision 1) > - jankSuffix = ` (${deltaAlerts.alerts.longestDuration || 0} alerts)`; > - cpowSuffix = ` (${deltaAlerts.alerts.totalCPOWTime || 0} alerts)`; > + jankSuffix = ` (${deltaAlerts.get("longestDuration") || 0} alerts)`; > + cpowSuffix = ` (${deltaAlerts.get("totalCPOWTime") || 0} alerts)`; hmm this is getting complicated.. I can't find in the code where to verify that this is correct... Where are the standard alert objects converted to maps? And wouldn't that still be `deltaAlerts.alerts.get` ?
Attachment #8698333 -
Flags: review?(felipc)
Assignee | ||
Comment 4•8 years ago
|
||
https://reviewboard.mozilla.org/r/27855/#review25481 > hmm this is getting complicated.. I can't find in the code where to verify that this is correct... Where are the standard alert objects converted to maps? And wouldn't that still be `deltaAlerts.alerts.get` ? That's actually in AddonWatcher.jsm, in `get alerts()`, which always returns a map, without a field `alerts`.
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(felipc)
Comment 5•8 years ago
|
||
Comment on attachment 8698333 [details] MozReview Request: Bug 1230735 - AddonWatcher.alerts is now a map;r?felipe https://reviewboard.mozilla.org/r/27855/#review26193
Attachment #8698333 -
Flags: review+
Updated•8 years ago
|
Flags: needinfo?(felipc)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dteller
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8698333 [details] MozReview Request: Bug 1230735 - AddonWatcher.alerts is now a map;r?felipe https://reviewboard.mozilla.org/r/27855/#review26551
Attachment #8698333 -
Flags: review+
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ab085ca3826b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Assignee | ||
Comment 9•8 years ago
|
||
Apparently, it's broken again.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•8 years ago
|
||
Actually, upgrading to the latest Nightly, it seems to work again. False alarm, I guess.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•