Closed Bug 1230747 Opened 7 years ago Closed 7 years ago

Fix element id in SpiderMonkey Bytecode Descriptions.

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox45 --- affected
firefox46 --- fixed

People

(Reporter: arai, Assigned: arai)

Details

Attachments

(1 file)

Fix element id generation rule for bytecode documentation.
2.52 KB, patch
Waldo
: review+
Details | Diff | Splinter Review 
We should fix following changes in make_opcode_doc.py

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Internals/Bytecode$compare?locale=en-US&to=954279&from=954261

So, we should use "_" instead of "-" for space, and add "_2" for duplicated id, as there are 2 "Debugger" entries now.
There could be (and actually there are) 2 types with same name under different category, so suffix is cached for each category+type.
Assignee: nobody → arai.unmht
Attachment #8700005 - Flags: review?(jwalden+bmo)
Attachment #8700005 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f43945ffc59f6fcc5d91c8321e7cb6af648b1c52
Bug 1230747 - Fix element id generation rule for bytecode documentation. r=jwalden
https://hg.mozilla.org/mozilla-central/rev/f43945ffc59f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.