Closed Bug 1230750 Opened 4 years ago Closed 4 years ago

Add all generated headers in GENERATED_FILES to EXPORTS, remove Makefile.in INSTALL_TARGETS rules

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: ted, Assigned: ajkerrigan, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug 1160185 added handling for files listed in GENERATED_FILES to be listed in EXPORTS, like so (the ordering is not important):
```
GENERATED_FILES += ['g.h']
EXPORTS += ['!g.h']
```

That patch only fixed one instance though:

https://hg.mozilla.org/integration/mozilla-inbound/diff/3ca0a1e37264/accessible/xpcom/moz.build
https://hg.mozilla.org/integration/mozilla-inbound/diff/3ca0a1e37264/accessible/xpcom/Makefile.in

We have a bunch of places in the tree right now where there are headers in GENERATED_FILES and then INSTALL_TARGETS rules in Makefile.in to export them:
https://dxr.mozilla.org/mozilla-central/search?q=path%3Amoz.build+regexp%3AGENERATED_FILES.*\.h&redirect=true&case=false

We should fix these all to just list the files in EXPORTS and remove the Makefile.in bits.
Hi, do you think this bug is suitable for a beginner and if it is, could you please tell me how I could go about solving it?
Hi, Varun - This probably isn't a good starter bug, but if you'd like to email me and tell me a bit about your skillset I can connect you with one.
I'd like to work on this bug. Would you mind assigning it to me?
Flags: needinfo?(mhoye)
You've got it. Ted, I'd like to introduce you to AJ; AJ, if you've got any questions about this Ted is good people, and you can needinfo him by picking "mentor".
Assignee: nobody → ajkerrigan
Flags: needinfo?(mhoye)
Hey AJ! If you look at the dxr link in comment 0 you can see the list of places that need fixing. If you don't want to tackle them all at once feel free to file separate bugs to work on them one at a time (or a few at a time, whatever works).

If you look at the hg.mozilla.org diff links there you can see what fixing a single instance of this looks like. Feel free to ping me on IRC (as ted) or email me directly if you have questions.
Add GENERATED_FILES headers to EXPORTS inside moz.build, and
remove associated Makefile.in rules.

Review commit: https://reviewboard.mozilla.org/r/32157/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32157/
Attachment #8711409 - Flags: review?(ted)
Attachment #8711409 - Flags: review?(ted) → review+
Comment on attachment 8711409 [details]
MozReview Request: Bug 1230750 - Export GENERATED_FILES headers from moz.build; r?ted.mielczarek

https://reviewboard.mozilla.org/r/32157/#review28979

This set of changes looks good, thanks!
Depends on: 1242663
Waiting to request check-in until Bug 1242663 lands, so this fix won't require a clobber.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/296dab0a417b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.