Closed
Bug 1230778
Opened 9 years ago
Closed 9 years ago
[trunk] make package is broken if --disable-tests is used in .mozconfig
Categories
(Thunderbird :: Build Config, defect)
Tracking
(thunderbird44 unaffected, thunderbird45+ fixed, thunderbird46 fixed)
RESOLVED
FIXED
Thunderbird 46.0
Tracking | Status | |
---|---|---|
thunderbird44 | --- | unaffected |
thunderbird45 | + | fixed |
thunderbird46 | --- | fixed |
People
(Reporter: fredbezies, Assigned: aleth)
Details
Attachments
(2 files, 1 obsolete file)
1.24 KB,
text/plain
|
Details | |
2.30 KB,
patch
|
jcranmer
:
review+
rkent
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
This is a really recent bug. It must have started on December 3rd. After a complete build session, when I enter objdir to package thunderbird, I got an error related to a missing file : bin/components/components.manifest Error log is added on this bug report. There is a python error message. Could it be related to Python3 being the default version of Python on Archlinux ?
Reporter | ||
Comment 1•9 years ago
|
||
I thought it was related to a "rotten copy" of Mozilla Thunderbird source code, but I still get this error :(
Reporter | ||
Comment 2•9 years ago
|
||
Here is what I get with ./mozilla/mach package [fred@fredo-arch src]$ ./mozilla/mach package 0:00.14 /usr/bin/make -C . -j3 -s -w package 0:00.17 make: Entering directory '/home/fred/logs/mail/objdir-tb' 0:00.50 make[1]: Entering directory '/home/fred/logs/mail/objdir-tb/mail/installer' 0:00.82 make[2]: Entering directory '/home/fred/logs/mail/objdir-tb/mail/installer' 0:01.10 make[3]: Entering directory '/home/fred/logs/mail/objdir-tb/mail/installer' 0:01.57 Error: /home/fred/logs/mail/objdir-tb/mail/installer/package-manifest:83: Missing file(s): bin/components/components.manifest 0:03.30 Traceback (most recent call last): 0:03.30 File "/home/fred/logs/mail/src/mozilla/toolkit/mozapps/installer/packager.py", line 406, in <module> 0:03.30 main() 0:03.30 File "/home/fred/logs/mail/src/mozilla/toolkit/mozapps/installer/packager.py", line 358, in main 0:03.31 copier.add(mozpath.join(respath, 'removed-files'), removals) 0:03.31 File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__ 0:03.31 self.gen.next() 0:03.31 File "/home/fred/logs/mail/src/mozilla/python/mozbuild/mozpack/errors.py", line 131, in accumulate 0:03.31 raise AccumulatedErrors() 0:03.31 mozpack.errors.AccumulatedErrors 0:03.32 /home/fred/logs/mail/src/mozilla/toolkit/mozapps/installer/packager.mk:41: recipe for target 'stage-package' failed 0:03.32 make[3]: *** [stage-package] Error 1 0:03.32 make[3]: Leaving directory '/home/fred/logs/mail/objdir-tb/mail/installer' 0:03.32 /home/fred/logs/mail/src/mozilla/toolkit/mozapps/installer/packager.mk:90: recipe for target 'make-package' failed 0:03.32 make[2]: *** [make-package] Error 2 0:03.33 make[2]: Leaving directory '/home/fred/logs/mail/objdir-tb/mail/installer' 0:03.33 /home/fred/logs/mail/src/mozilla/config/rules.mk:547: recipe for target 'default' failed 0:03.33 make[1]: *** [default] Error 2 0:03.33 make[1]: Leaving directory '/home/fred/logs/mail/objdir-tb/mail/installer' 0:03.33 /home/fred/logs/mail/src/mozilla/../mail/build.mk:10: recipe for target 'package' failed 0:03.33 make: *** [package] Error 2 0:03.33 make: Leaving directory '/home/fred/logs/mail/objdir-tb' Any idea ?
Reporter | ||
Comment 3•9 years ago
|
||
If it could help, here is my .mozconfig (adapted for archlinux) : mk_add_options PYTHON=/usr/bin/python2 mk_add_options AUTOCONF=autoconf-2.13 mk_add_options MOZ_OBJDIR=/home/fred/logs/mail/objdir-tb mk_add_options MOZ_MAKE_FLAGS="-j3" ac_add_options --enable-application=mail ac_add_options --enable-calendar ac_add_options --with-ccache ac_add_options --disable-debug ac_add_options --disable-tests ac_add_options --disable-crashreporter ac_add_options --disable-warnings-as-errors ac_add_options --disable-debug-symbols ac_add_options --disable-elf-hack ac_add_options --enable-gstreamer=1.0
Reporter | ||
Updated•9 years ago
|
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Reporter | ||
Updated•9 years ago
|
Summary: make package is broken after an error in mail/installer/package-manifest on Archlinux → [trunk] make package is broken if --disable-tests is used in .mozconfig
Reporter | ||
Comment 4•9 years ago
|
||
After some chat on #maildev, looks like installer is working only if --disable-tests is removed. Any idea why ?
Assignee | ||
Comment 5•9 years ago
|
||
components.manifest contains 22:07:17 - fredbezies: binary-component libtest656331.so 22:07:17 - fredbezies: binary-component libtestcompnoaslr.so 22:07:17 - fredbezies: binary-component libtestcomponent.so Probably with disable-tests it is empty or is not generated at all, so its packaging fails.
Reporter | ||
Comment 6•9 years ago
|
||
So why it is not generated ? Even a empty file to workaround this bug, or am I wrong ?
Assignee | ||
Comment 7•9 years ago
|
||
Given that when starting a TB build (with tests), we get (in the error console) Failed to load native module at path 'Daily.app/Contents/Resources/components/libtest656331.dylib': (80004005) <unknown; can't get error from NSPR> Failed to load native module at path 'Daily.app/Contents/Resources/components/libtestcompnoaslr.dylib': (80004005) <unknown; can't get error from NSPR> Failed to load native module at path 'Daily.app/Contents/Resources/components/libtestcomponent.dylib': (80004005) <unknown; can't get error from NSPR> there's something wrong here.
Assignee | ||
Updated•9 years ago
|
status-thunderbird45:
--- → affected
tracking-thunderbird45:
--- → ?
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8696503 -
Flags: review?(Pidgeot18)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•9 years ago
|
||
jcranmer: bug 821291 also does s/#include "nsStringAPI.h"/#include "nsString.h" in some places; are there cases in c-c where this would be appropriate too?
Assignee | ||
Comment 10•9 years ago
|
||
Might as well include IB.
Attachment #8696505 -
Flags: review?(Pidgeot18)
Assignee | ||
Updated•9 years ago
|
Attachment #8696503 -
Attachment is obsolete: true
Attachment #8696503 -
Flags: review?(Pidgeot18)
Assignee | ||
Comment 11•9 years ago
|
||
Note this patch doesn't resolve comment 7.
Comment 12•9 years ago
|
||
(In reply to aleth [:aleth] from comment #9) > jcranmer: bug 821291 also does s/#include "nsStringAPI.h"/#include > "nsString.h" in some places; are there cases in c-c where this would be > appropriate too? nsStringAPI is used for external linkage, while nsString for internal. The only places I see nsStringAPI in mailnews are contexts where external linkage is clearly needed (C++ tests and addons).
Assignee | ||
Comment 13•9 years ago
|
||
(In reply to aleth [:aleth] from comment #11) > Note this patch doesn't resolve comment 7. Filed as bug 1230998.
Comment 14•9 years ago
|
||
Comment on attachment 8696505 [details] [diff] [review] Port changes from bug 821291 (move libmozgnome into libxul) for c-c Review of attachment 8696505 [details] [diff] [review]: ----------------------------------------------------------------- rs+
Attachment #8696505 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 15•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/cace0ff88a9c0c2d3d56037b9e7c58f8eece4105 Bug 1230778 - Port changes from bug 821291 (move libmozgnome into libxul) for c-c. r=jcranmer
Assignee | ||
Comment 16•9 years ago
|
||
Comment on attachment 8696505 [details] [diff] [review] Port changes from bug 821291 (move libmozgnome into libxul) for c-c [Approval Request Comment] Regression caused by (bug #): Bug 821291 (mozilla 45) Risk to taking this patch (and alternatives if risky): straightforward port
Attachment #8696505 -
Flags: approval-comm-aurora?
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Comment 17•9 years ago
|
||
Comment on attachment 8696505 [details] [diff] [review] Port changes from bug 821291 (move libmozgnome into libxul) for c-c https://hg.mozilla.org/releases/comm-aurora/rev/2fbcc55372e4
Attachment #8696505 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Updated•9 years ago
|
status-thunderbird44:
--- → unaffected
status-thunderbird46:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•