123078 - drawings of checkmarks and "x" not appearing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Laura Krietemeyer]

I'm using trunk build, build ID 2002012503Go to this site and click on an answer
button.  In Netscape 4.7 a drawing of checkmark or a drawing of an "X" will
appear to the left of the questions to let you know whether or not you got the
question right.  This feature is not working in Netscape 6.  

In the javascript console I see this:

Error: document[questionNum] has no properties
Source File: http://www.triviatribute.com/scoredquiz1.html
Line: 103

Comment 1

[Phil Schwartau]

Confirming bug with a Linux build from the same date. 
OS: Win98 ---> All.


The radio buttons at the site are given this way in HTML:


<table BORDER=0>
<tr>
<td ALIGN=CENTER VALIGN=CENTER WIDTH=100>
<img SRC="clear.gif" HEIGHT=60 WIDTH=60 NAME=1></td>
<td>
<form>
<b>1.  What role did Bill Bixby play?  etc. etc. </b><br>
<input type=radio name=1 value="a" onClick="Engine(1, this.value)">Tim 
O'Hara<br>
<input type=radio name=1 value="b" onClick="Engine(1, this.value)">The Police 
Chief<br>
<input type=radio name=1 value="c" onClick="Engine(1, this.value)">Uncle Martin 
(the Martian)<br>
<input type=radio name=1 value="d" onClick="Engine(1, this.value)">Detective 
Bill Brennan<p>
</form>

</td> </tr>
<tr>
<td ALIGN=CENTER VALIGN=CENTER>
<img SRC="clear.gif" HEIGHT=60 WIDTH=60 NAME=2></td>
<td> <form>
<b>2.  In the 1965 film,  etc. etc. </b><br>
<input type=radio name=2 value="a" onClick="Engine(2, this.value)">Food<br>
<input type=radio name=2 value="b" onClick="Engine(2, this.value)">Fuel<br>
<input type=radio name=2 value="c" onClick="Engine(2, 
this.value)">Ammunition<br>
<input type=radio name=2 value="d" onClick="Engine(2, this.value)">Tanks<p>
</form>

                         etc.
                         etc.

Comment 2

[Phil Schwartau]

If you try this site in NN4.7, you see the images to the left of
the questions as soon as you click on an answer. They are called
"correct.gif" and "incorrect.gif". I tried this javascript:URL 


javascript:
var obj = document[1];
var s = obj + '\n' + obj.name + '\n'  + obj.src;
alert(s);


In NN4.7, before answering question 1, I get this:

                 [object Image]
                 1
                 http://www.triviatribute.com/clear.gif   

                    etc.


After answering the question, the src property changes
from "clear.gif" to "correct.gif" or "incorrect.gif".


If you try it in IE6, you get

                 [object]
                 1
                 http://www.triviatribute.com/clear.gif


But for some reason, in IE6 these images never do change to 
"correct.gif" or "incorrect.gif" and the used never sees them.
Will investigate -


If you try this same javascript:URL in Mozilla, you just get 
an error in the JS Console:  "Error: obj has no properties"

Comment 3

[Phil Schwartau]

Ressigning to DOM Level 0: this is the site I was talking about.

The <IMGS> and radio buttons are grouped and given names like 1, 2, etc.;
and then are accessed as document[1], document[2], etc. This seems to be 
accepted by IE6, NN4.7, but not by Mozilla, where document[1] is coming up
as undefined -

Comment 4

[Phil Schwartau]

Really reassigning - 

Comment 5

[Johnny Stenback (:jst)]

Attachment: Proposed fix.

Comment 6

[Johnny Stenback (:jst)]

Peter, would you review?

Comment 7

[Peter Van der Beken [:peterv]]

Comment on attachment 67552 [details] [diff] [review]
Proposed fix.

r=peterv.

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 67552 [details] [diff] [review]
Proposed fix.

rpotts says sr=rpotts.

Rick noticed while reviewing this that the attached patch will make
document[null] resolve to document["null"], but it does the same in 4x too, so
we're ok :-)

Comment 9

[Johnny Stenback (:jst)]

Fixed.