1230794 - Removing a "Search provider" from settings has no way to undo-ing

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I noticed this the other day, I think it used to be greyed out? but now I can't figure out how to add the removed provider back. 

---

STR:

1) Settings > Search
2) Press on search provider -> Remove
3) See search provider missing from the list

Comment 1

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #0)
> I noticed this the other day, I think it used to be greyed out? but now I
> can't figure out how to add the removed provider back. 
> 
> ---
> 
> STR:
> 
> 1) Settings > Search
> 2) Press on search provider -> Remove
> 3) See search provider missing from the list

You can restore your defaults from the 3-dot menu in settings.

Supporting undo could be tricky... maybe we could use a snackbar, and not do the actual removing until the snackbar goes away.

But I don't think this is a regression, so I'm not sure we need this.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #1)

> You can restore your defaults from the 3-dot menu in settings.
> 
> Supporting undo could be tricky... maybe we could use a snackbar, and not do
> the actual removing until the snackbar goes away.
> 
> But I don't think this is a regression, so I'm not sure we need this.

Could we disable it (visually) in the same manner as disabling a Home Panel? 

Also, I dont think my "restore" is working either :\

Comment 3

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #2)
> (In reply to :Margaret Leibovic from comment #1)
> 
> > You can restore your defaults from the 3-dot menu in settings.
> > 
> > Supporting undo could be tricky... maybe we could use a snackbar, and not do
> > the actual removing until the snackbar goes away.
> > 
> > But I don't think this is a regression, so I'm not sure we need this.
> 
> Could we disable it (visually) in the same manner as disabling a Home Panel? 
> 
> Also, I dont think my "restore" is working either :\

Gah, that's because bug 1221513 didn't land.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.