1230847 - Callback of runEmulatorCmd/runEmulatorShell doesn't be triggered correctly when running two requests in parallel

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Edgar Chen [:edgar]]

Bug 1211489 allows running requests in parallel, but when test script execute two runEmulatorCmd in parallel, only callback will be triggered correctly. After checking the log, marionette did receive both response, but only one callback is triggered.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

I found Bug 1211489 changed to use |asyncTestCommandId| as id for every runEmulator* message which causes problem on handling parallel request. In this patch, I just rollback to use increasing |_emu_cb_id| as id, not sure if this is a good way to fix this. :ato, could you take a look at the patch? Thank you.

Comment 2

[Andreas Tolfsen ❲:ato❳]

This patch looks fine to me.  Can you please submit it to mozreview?

Comment 3

[Edgar Chen [:edgar]]

Attachment: MozReview Request: Bug 1230847 - Use increasing value as id for runEmulatorCmd and runEmulatorShell. r?ato

Bug 1230847 - Use increasing value as id for runEmulatorCmd and runEmulatorShell. r?ato

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8696968 [details]
MozReview Request: Bug 1230847 - Use increasing value as id for runEmulatorCmd and runEmulatorShell. r?ato

https://reviewboard.mozilla.org/r/27443/#review24755

Comment 5

[Andreas Tolfsen ❲:ato❳]

Please do a try run before integrating.

Comment 6

[Edgar Chen [:edgar]]

(In reply to Andreas Tolfsen (:ato) from comment #5)
> Please do a try run before integrating.

Sure, will do this. Thank you.

Comment 7

[Edgar Chen [:edgar]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b3ee7757c49&exclusion_profile=false&group_state=expanded

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/bfb273191c68

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfb273191c68