If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove Gradle configuration rooted in the object directory

RESOLVED FIXED in Firefox 46

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

Trunk
Firefox 46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 affected, firefox46 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Now that Bug 1107811 and Bug 1123416 are landed, we can remove the stop-gap symlinking Gradle configuration in the object directory.  \o/

That means removing:

1) mach gradle-install;
2) mobile/android/gradle;
3) possibly mobile/android/base/docs/gradle.rst.  (Alternatively, update it.)
(Assignee)

Comment 1

2 years ago
Created attachment 8696372 [details]
MozReview Request: Bug 1230848 - Remove Gradle configuration rooted in the object directory. r?gps

Bug 1230848 - Remove Gradle configuration rooted in the object directory. r?gps

The top source directory configuration requires
mobile/android/gradle/m2repo/**, so it stays.  There's no value
changing the location; it contains an Android-specific Gradle plugin.

We note the removal of |mach gradle-install| and point to the new
documentation.
Attachment #8696372 - Flags: review?(gps)

Updated

2 years ago
Attachment #8696372 - Flags: review?(gps) → review+

Comment 2

2 years ago
Comment on attachment 8696372 [details]
MozReview Request: Bug 1230848 - Remove Gradle configuration rooted in the object directory. r?gps

https://reviewboard.mozilla.org/r/27317/#review25031

Sure.

FWIW, it is somewhat dangerous to assume there will only ever be a single Gradle/Android project in mozilla-central. I'd prefer things to be rooted under mobile/android. But I reckon we can cross this bridge another day. I also don't fully understand how this works. But meh.
(Assignee)

Comment 3

2 years ago
(In reply to Gregory Szorc [:gps] from comment #2)
> Comment on attachment 8696372 [details]
> MozReview Request: Bug 1230848 - Remove Gradle configuration rooted in the
> object directory. r?gps
> 
> https://reviewboard.mozilla.org/r/27317/#review25031
> 
> Sure.
> 
> FWIW, it is somewhat dangerous to assume there will only ever be a single
> Gradle/Android project in mozilla-central. I'd prefer things to be rooted
> under mobile/android. But I reckon we can cross this bridge another day. I
> also don't fully understand how this works. But meh.

I agree, but the IDEA-based environments assume all files referenced are under the root source directory.  Since we want to reference toolkit/ and other toplevel things, the root needs to be at the top level.

However, Gradle supports this all just fine.  We can move Android-specific things deeper into the tree (into mobile/android, for example) and grow a second configuration somewhere else.  (And IDEA-based environment support will work, to the best of my knowledge.)
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/93d733169c2151b471eab2a8c24a1ecd67487457
Bug 1230848 - Remove Gradle configuration rooted in the object directory. r=gps
(Assignee)

Updated

2 years ago
Assignee: nobody → nalexander
Status: NEW → ASSIGNED

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/93d733169c21
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
You need to log in before you can comment on or make changes to this bug.