1230856 - Update RAE Dictionary search plugin to query against the 23rd edition (Thunderbird)

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[RickieES aka Ricardo Palomares]

Attachment: Patch to update drae.xml to query the 23rd edition of RAE dictionary

+++ This bug was initially created as a clone of Bug #1230853 +++

The RAE (Real Academia Española), the institution that sets rules regarding Spanish idiom across all Spanish speaking variants, has updated its online dictionary query service to point to the 23rd edition of its dictionary. This bug is to update the shipped search plugin in es-ES to the new URL, but this time for Thunderbird instead Firefox.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 8696370 [details]
Patch to update drae.xml to query the 23rd edition of RAE dictionary

Sorry, I'm no longer active on Thunderbird. Passing over to Philipp.

Comment 2

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8696370 [details]
Patch to update drae.xml to query the 23rd edition of RAE dictionary

Looks good, thanks for asking for review. r=philipp

Comment 3

[RickieES aka Ricardo Palomares]

The equivalent patch for Firefox has been not granted, so I will have to make some changes and will provide a new patch also for Thunderbird, if not for other reasons, at the very least to keep search plugins consistent across products. Sorry if that causes extra work for you.

Comment 4

[RickieES aka Ricardo Palomares]

Attachment: Patch to update drae.xml to query the 23rd edition of RAE dictionary, 2nd version

Francesco Lodolo has reviewed and advised some changes to the searchplugin for Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1230853#c7), so now that the patch in the corresponding bug has been approved, I'm providing the updated version here, too. Again, sorry for the duplicated work; I think that it is better to keep the searchplugin aligned in both products.

Comment 5

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8696761 [details] [diff] [review]
Patch to update drae.xml to query the 23rd edition of RAE dictionary, 2nd version

Review of attachment 8696761 [details] [diff] [review]:
-----------------------------------------------------------------

No problem at all, luckily reviewing these patches is pretty quick. I agree it is better to have them in sync!

Comment 6

[RickieES aka Ricardo Palomares]

So, landed in Aurora:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-ES/rev/d2b4c98885a0

And imported and merged into Central with this changeset (that includes also the patch for Firefox):

http://hg.mozilla.org/l10n-central/es-ES/rev/6fef32243f0f

Thanks again

Comment 7

[RickieES aka Ricardo Palomares]

(In reply to [:rickiees] Ricardo Palomares from comment #6)
> So, landed in Aurora:
> 
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-ES/rev/d2b4c98885a0
>

Oops, sorry, this is the right changeset for Thunderbird:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-ES/rev/81b69032e001