1230882 - Remove DecodedStream::BeginShutdown()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

It doesn't fit into the interface of MediaSink and is confusing with Shutdown().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a98d463ce7cd

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1230882. Part 1 - destroy DecodedStreamData properly when dispatch fails. r=roc.

Bug 1230882. Part 1 - destroy DecodedStreamData properly when dispatch fails. r=roc.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1230882. Part 2 - remove DecodedStream::BeginShutdown() and other unused code. r=roc.

Bug 1230882. Part 2 - remove DecodedStream::BeginShutdown() and other unused code. r=roc.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8696568 [details]
MozReview Request: Bug 1230882. Part 1 - destroy DecodedStreamData properly when dispatch fails. r=roc.

https://reviewboard.mozilla.org/r/27375/#review24927

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8696569 [details]
MozReview Request: Bug 1230882. Part 2 - remove DecodedStream::BeginShutdown() and other unused code. r=roc.

https://reviewboard.mozilla.org/r/27377/#review24929

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0661db5a84
https://hg.mozilla.org/integration/mozilla-inbound/rev/796aa6700541

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fe0661db5a84
https://hg.mozilla.org/mozilla-central/rev/796aa6700541