Closed
Bug 1230887
Opened 9 years ago
Closed 8 years ago
Request too large
Categories
(Participation Infrastructure :: Phonebook, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: anhcuongrau90-1, Assigned: contato, Mentored)
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 Build ID: 20151029151421 Steps to reproduce: 1. input: a new post to search input. 2. Tap btn [Search]. Actual results: => Actual Reuslt: slow and hang Firefox, message response: "Request too large"! Expected results: limit the search length.
Updated•8 years ago
|
Version: 2014-01.1 → other
Updated•8 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•8 years ago
|
Mentor: jgiannelos
Comment 1•8 years ago
|
||
Let's limit this one to 140 chars. In order to tackle this one we just need to change the `max_length` validator to 140 of `q` field in `mozillians.phonebook.forms.Searchform` https://docs.djangoproject.com/en/1.8/ref/forms/fields/#charfield
Updated•8 years ago
|
Assignee: nobody → contato
Assignee | ||
Comment 2•8 years ago
|
||
I think finish this bug, I send one pull request in github https://github.com/mozilla/mozillians/pull/1350.
Flags: needinfo?(jgiannelos)
Comment 3•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla/mozillians https://github.com/mozilla/mozillians/commit/e679a790f1ed30c449eb45e740a7b6903be0b8dc [Fix bug 1230887] Add max character limit in search form fields https://github.com/mozilla/mozillians/commit/15cf97dc1cf77ac540004411341e6adb629487a0 Merge pull request #1359 from Ladeia/bug1230887 [Fix bug 1230887] Add max character limit in search form fields
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Flags: needinfo?(jgiannelos)
Updated•8 years ago
|
Version: other → next
Comment 4•8 years ago
|
||
Verified on stage: * Large search string raises an error in prod * The same strings gets restricted because of max length in stage * Search is not raising an error because of the large string in stage
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Version: next → 2016-3.3
You need to log in
before you can comment on or make changes to this bug.
Description
•