1230906 - Clear Recent History dialog not closing

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[mail]

Attachment: ClearRecentHistory.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 2015103000

Steps to reproduce:

1) Select History>Clear Recent History
2) Select "Last hour" and click OK


Actual results:

Dialog does not close but is stuck on "Clearing..."  infinitely. Closing the window does work though and FF cont. to work as expected. 



Expected results:

Dialog should close by itself.

Comment 1

[Marco Bonardo [:mak]]

(In reply to mail from comment #0)
> Dialog does not close but is stuck on "Clearing..."  infinitely.

What does infinitely mean? did you try to let it proceed (even for lots of time). I know for some users it takes quite a while... It's wrong regardless but it would involve a different kind of investigation.

Comment 2

[mail]

(In reply to Marco Bonardo [::mak] from comment #1)
> (In reply to mail from comment #0)
> > Dialog does not close but is stuck on "Clearing..."  infinitely.
> 
> What does infinitely mean? did you try to let it proceed (even for lots of
> time). I know for some users it takes quite a while... It's wrong regardless
> but it would involve a different kind of investigation.

I don't have my Linux notebook with me, but I tried on my MacBook Pro (MacBookPro8,1; OS X 10.9.5; FF 42.0) and the dialog was up for 1 1/2 hours before I closed it manually. The firefox process was just idling at 0% the whole time. I'll try on the Linux box tomorrow.

Comment 3

[Marco Bonardo [:mak]]

ok, we recently changed the code to use promises, and I wonder if that somehow caused this misbehavior in edge cases.

Please report any errors you see in the Browser Console when that happens.

Comment 4

[mail]

Tried on Linux this morning (openSuse 13.1, FF 42) and the same happened. I let i run for more than 4 hours before closing the the dialog. Nothing was logged to the Console. The firefox process was idling 0% the whole time.

Comment 5

[mail]

Update: I just started FF from the CLI, tried cleaning the history and indeed it logged an exception when resolving a promise Here's the log:

Vector smash protection is enabled.
RemoveFilesRecursively: unlink dir: Directory not empty
RemoveFilesRecursively: unlink dir: Directory not empty
RemoveFilesRecursively: unlink dir: Directory not empty
RemoveFilesRecursively: unlink dir: Directory not empty
RemoveFilesRecursively: unlink dir: Directory not empty
RemoveFilesRecursively: unlink dir: Directory not empty
RemoveFilesRecursively: unlink dir: Directory not empty
RemoveFilesRecursively: unlink dir: Directory not empty
*************************
A coding exception was thrown in a Promise resolution callback.
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Full message: ReferenceError: Cu is not defined
Full stack: Sanitizer.prototype.sanitize/ok<@chrome://browser/content/sanitize.js:110:11
Sanitizer.prototype.items.cookies.clear/<@chrome://browser/content/sanitize.js:241:13
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:1
Sanitizer.showUI@chrome://browser/content/sanitize.js:732:1
Sanitizer.sanitize@chrome://browser/content/sanitize.js:746:3
BG_sanitize@jar:file:///usr/lib64/firefox/browser/omni.ja!/components/nsBrowserGlue.js:2053:5
oncommand@chrome://browser/content/browser.xul:1:1

*************************

Comment 6

[Marco Bonardo [:mak]]

(In reply to mail from comment #5)
> A coding exception was thrown in a Promise resolution callback.
> See
> https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/
> Promise
> 
> Full message: ReferenceError: Cu is not defined
> Full stack:
> Sanitizer.prototype.sanitize/ok<@chrome://browser/content/sanitize.js:110:11
> Sanitizer.prototype.items.cookies.clear/<@chrome://browser/content/sanitize.
> js:241:13


This is relevant, but that code doesn't exist anymore in Firefox 44 (fixed by the changes in bug 1089695)

Basically an exception was thrown when clearing cookies and we were trying to reportError it using Cu.reportError, but Cu was not defined in this context.
Bug 1089695 removed that piece of code so also this bug should be gone.

I'm marking it as WFM in Firefox 44. Firefox 43 is about to be released and we can't fix this bug in it anymore.

Comment 7

[mail]

Ok, good to know. 

Thanks a lot for your efforts.