Closed Bug 1230907 Opened 5 years ago Closed 5 years ago

[Static Analysis][Uninitialized scalar field] Constructor of nsBMPDecoder from nsBMPDecoder.cpp

Categories

(Core :: ImageLib, defect)

Product:
Core
Component:
ImageLib
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox45 --- affected
firefox48 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1338042)

Attachments

(1 file)

Bug 1230907.diff
765 bytes, patch
seth
: review+
Details | Diff | Splinter Review 
The Static Analysis tool Coverity added that mPixelRowSize is not initialized in the constructor.
Attached patch Bug 1230907.diff — — Splinter Review 
Hello Seth,

Could you please take a look other this patch?

THX
Attachment #8696439 - Flags: review?(seth)
Whiteboard: CID 1338042
Comment on attachment 8696439 [details] [diff] [review]
Bug 1230907.diff

Review of attachment 8696439 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks for finding this!
Attachment #8696439 - Flags: review?(seth) → review+
https://hg.mozilla.org/mozilla-central/rev/eceb5235a54d
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.