1230933 - pdfjs not showing icons associated to embedded attachments

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Janez Košmrlj]

Attachment: example pdf file

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20151104125556

Steps to reproduce:

We have some internal PDF's wiit embedded attachments. I can see a pin icon, but i can't click on it. I found a simmilar pdf on the web, but here i can't see any icons.

I use firefox 38 ESR on Linux but i also tried firefox 42 on windows with the same result.


Actual results:

 I can see a pin icon, but i can't click on it. 


Expected results:

Clicking the pin icon should open the attachment.
Other pdf viewers i use work with this kind of icons normaly.

Comment 1

[Loic]

The feature "File Attachment" in unimplemented.

Comment 2

[Janez Košmrlj]

Are there any plans to implement it?

Comment 3

[Yury Delendik (:yury)]

Janez, there is a basic support for attachments in PDF viewer, see https://github.com/mozilla/pdf.js/pull/4329 (but that issue is talking about "File Attachment" annotation) In the future, we are planning to address commonly used annotation types as well.

Comment 4

[Kenan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0

I cannot see the pin icon (in Acrobat Reader it is visible, in Chrome not). But I can open the attched files. So I would suggest to set this bug on fixed or worksforme.

Comment 5

[Marco Castelluccio [:marco]]

Brendan, is it expected that we are not able to see the pin icons?

Comment 6

[Brendan Dahl [:bdahl]]

The icons do appear in acrobat. After a quick look I wasn't able to tell why the icons aren't showing. Could be unsupported annotation type or image type.

Comment 7

[Kenan]

If this still exists, we should reopen the bug.

Comment 8

[Jonas Jenwald [:Snuffleupagus]]

Attachment: pr 15747: Add default icons for FileAttachment annotations (bug 1230933)

Comment 9

[Jonas Jenwald [:Snuffleupagus]]

:marco, can you please help ping the relevant UI/UX team so that can get appropriate icons since that's basically the only blocker here?

The other option, since FileAttachment annotations without an appearance seem extremely rare, could be that we simply pick some reasonable looking e.g. CC0-licensed icons online (to avoid having to wait a long time for UI/UX)?

Comment 10

[Gregory Pappas [:gregp]]

Not marco but

If you need icons, you might be able to borrow some from comm-central:
https://searchfox.org/comm-central/source/mail/themes/shared/mail/icons/attach.svg
https://searchfox.org/comm-central/source/mail/themes/shared/mail/icons/new/compact/pin.svg
https://searchfox.org/comm-central/source/mozilla/browser/themes/shared/icons/pin-12.svg
https://searchfox.org/comm-central/search?q=&path=.svg&case=false&regexp=false

Comment 11

[Jonas Jenwald [:Snuffleupagus]]

(In reply to Gregory Pappas [:gregp] from comment #10)

If you need icons, you might be able to borrow some from comm-central:
https://searchfox.org/comm-central/source/mail/themes/shared/mail/icons/attach.svg
https://searchfox.org/comm-central/source/mail/themes/shared/mail/icons/new/compact/pin.svg
https://searchfox.org/comm-central/source/mozilla/browser/themes/shared/icons/pin-12.svg
https://searchfox.org/comm-central/search?q=&path=.svg&case=false&regexp=false

That's very helpful, thank you!

Comment 12

[Marco Castelluccio [:marco]]

Those icons look good to me, thanks Gregory! Since they are not prominent I think we can just use them without worrying too much.
For attachment, we also have https://github.com/mozilla/pdf.js/blob/master/web/images/toolbarButton-viewAttachments.svg which would be OK.
And for pin, https://searchfox.org/mozilla-central/source/browser/themes/shared/icons/pin-12.svg or https://searchfox.org/mozilla-central/source/browser/components/newtab/data/content/assets/glyph-pin-16.svg.