1230939 - [Static Analysis][Unchecked return value] Function CacheStorageService::DoomStorageEntries from CacheStorageService.cpp

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that the return value from: 

>>  sGlobalEntryTables->Get(aContextKey, &diskEntries);

is not checked and later on the succes of the function is checked with the value from diskEntries pointer:

>>  if (memoryEntries && diskEntries) {

In order to silence the analyzer i propose the attached patch.

Comment 1

[Andi [:andi]]

Attachment: Bug 1230939.diff

Hello Patrick,

Could you please take a look other this patch. Not only it silences the static analysis tool - Coverity but also i think it adds some performance gain since memoryEntries could be null, sGlobalEntryTables->Get(aContextKey, &diskEntries) will not get called.

THX

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8696463 [details] [diff] [review]
Bug 1230939.diff

Review of attachment 8696463 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing from Patrick (hope he doesn't mind) as this is my code.  This looks good.  Thanks.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/984b095feb49

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/984b095feb49