1230950 - [Static Analysis][Result is not floating-point] Function nsCSSRendering::PaintBorderWithStyleBorder from nsCSSRendering.cpp

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that the following codes:

>>  Float borderWidths[4] = { Float(border.top / twipsPerPixel),
>>                            Float(border.right / twipsPerPixel),
>>                            Float(border.bottom / twipsPerPixel),
>>                            Float(border.left / twipsPerPixel) };

will populate borderWidths with results that are casted to int and loosing precision. 

This behavior is present only when NS_COORD_IS_FLOAT is not defined.

Comment 1

[Andi [:andi]]

Attachment: Bug 1230950.diff

Hello David,

Can you please take a look at this patch?

THX

Comment 2

[Andi [:andi]]

Comment on attachment 8696468 [details] [diff] [review]
Bug 1230950.diff

Review of attachment 8696468 [details] [diff] [review]:
-----------------------------------------------------------------

because David is probably busy.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8696468 [details] [diff] [review]
Bug 1230950.diff

Please ask for review from whoever wrote or reviewed this code...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8696468 [details] [diff] [review]
Bug 1230950.diff

This seems like a substantive change in behavior, and I strongly suspect we want the current behavior (flooring to an integral number of pixels).

Comment 5

[Andi [:andi]]

Thx David i will wave the issue from Coverity.