Closed Bug 1230981 Opened 6 years ago Closed 6 years ago

Intermittent leakcheck | default process: 56 bytes leaked (WorkerRunnable, nsStringBuffer)

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 --- wontfix
firefox46 --- fixed
firefox47 --- fixed
firefox-esr45 --- affected

People

(Reporter: philor, Assigned: ejpbruel)

References

Details

(Keywords: intermittent-failure, memory-leak)

Given that this always seems to happen with a "INFO - DevToolsUtils.assert threw an exception: Error: Assertion failure: threadActor should exist when creating sources." in the log I'm going to speculate that it is the debugger's fault.
Flags: needinfo?(ejpbruel)
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #9)
> Given that this always seems to happen with a "INFO - DevToolsUtils.assert
> threw an exception: Error: Assertion failure: threadActor should exist when
> creating sources." in the log I'm going to speculate that it is the
> debugger's fault.

Thanks for bringing this bug to my attention.

I've seen that particular assertion failure in the debugger before, so I have a hunch what could trigger it, but I have no idea how that would lead to a leak though.

I'll put this bug on my watch list, but I'm not making it a priority for now. I will up the priority if the test starts to fail more often.
Flags: needinfo?(ejpbruel)
This is the #7 leak on OrangeFactor.

Leak stack:
 07:37:45     INFO -  #00: mozilla::dom::workers::WorkerRunnable::AddRef() [dom/workers/WorkerRunnable.cpp:239]
 07:37:45     INFO -  #01: mozilla::dom::workers::WorkerDebugger::PostMessageMoz(nsAString_internal const&, JSContext*) [dom/workers/WorkerPrivate.cpp:3837]
 07:37:45     INFO -  #02: NS_InvokeByIndex [xpcom/reflect/xptcall/md/unix/xptcinvoke_x86_64_unix.cpp:174]
 07:37:45     INFO -  #03: CallMethodHelper::Call() [js/xpconnect/src/XPCWrappedNative.cpp:1400]
 07:37:45     INFO -  #04: XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) [js/xpconnect/src/XPCWrappedNative.cpp:1367]
 07:37:45     INFO -  #05: XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) [js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1115]
 07:37:45     INFO -  #06: js::CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), JS::CallArgs const&) [js/src/jscntxtinlines.h:236]
 07:37:45     INFO -  #07: js::Invoke(JSContext*, JS::CallArgs const&, js::MaybeConstruct) [js/src/vm/Interpreter.cpp:466]
 07:37:45     INFO -  #08: Interpret [js/src/vm/Interpreter.cpp:2802]
 07:37:45     INFO -  #09: js::RunScript(JSContext*, js::RunState&) [js/src/vm/Interpreter.cpp:428]
 07:37:45     INFO -  #10: js::Invoke(JSContext*, JS::CallArgs const&, js::MaybeConstruct) [js/src/vm/Interpreter.cpp:496]
07:37:45 INFO - #11: js::fun_call(JSContext*, unsigned int, JS::Value*) [js/src/jsfun.cpp:1205]
Flags: needinfo?(ejpbruel)
Keywords: mlk
This might have been things in the event queue at shutdown, which we just fixed.
Like Kyle said in comment 15, this might have been fixed by now. Please needinfo me again if it has not.
Flags: needinfo?(ejpbruel)
Depends on: 1241841
No occurrences since bug 1241841 landed, let's declare victory here. Eddy, any chance we can try backporting the patch to 46? Probably too late for 45 given where we are in the cycle, though.
Assignee: nobody → ejpbruel
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.