Closed Bug 1231033 Opened 4 years ago Closed 4 years ago

Fix Fallout from Bug 1217133 gContentSecurityManager is not defined

Categories

(SeaMonkey :: Build Config, defect)

SeaMonkey 2.41 Branch
defect
Not set

Tracking

(seamonkey2.40 fixed, seamonkey2.41 fixed, seamonkey2.42 fixed, seamonkey2.43 fixed)

RESOLVED FIXED
seamonkey2.43
Tracking Status
seamonkey2.40 --- fixed
seamonkey2.41 --- fixed
seamonkey2.42 --- fixed
seamonkey2.43 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40
Build ID: 20151207084944

Steps to reproduce:

Compile Seamonkey for Windows, build the installer and install it using the installer


Actual results:

The follwoing errors are reported in the Web console.

Timestamp: 12/7/2015 11:22:48 PM
Error: NS_ERROR_XPC_BAD_IID: Component returned failure code: 0x80570018 (NS_ERROR_XPC_BAD_IID) [nsIJSCID.getService]
Source File: resource://gre/modules/XPCOMUtils.jsm
Line: 230

Timestamp: 12/7/2015 11:22:48 PM
Error: ReferenceError: gContentSecurityManager is not defined
Source File: resource://gre/modules/LoginManagerContent.jsm
Line: 1143

Seamonkey works but the Login manager might be broken for localhosts. I didin't test it yet.

This seems to be the result of Bug 1217133. dom_security.xpt is not picked up by the Seamonky installer build. 


Expected results:

No errors should be shown during startup.
Patch for comm-central
Attachment #8696560 - Flags: review?(bugspam.Callek)
Patch for Aurora. Original Bug 1231033 has also been uplifted to mozilla-aurora
Attachment #8696561 - Flags: review?(bugspam.Callek)
Attachment #8696560 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8696561 [details] [diff] [review]
1231033-gContentSecurityManager-aurora.patch

We'll need this on comm-beta and comm-release as well as comm-aurora
Attachment #8696561 - Flags: review?(bugspam.Callek)
Attachment #8696561 - Flags: review+
Attachment #8696561 - Flags: approval-comm-release+
Attachment #8696561 - Flags: approval-comm-beta+
Attachment #8696561 - Flags: approval-comm-aurora+
>> and comm-release

I have not seen errors in 2.40 and I use it now daily for 4 weeks. Which doesn't mean there are non. If the file is there it should be ok for comm-release :)
Flags: needinfo?(philip.chee)
(In reply to Frank-Rainer Grahl from comment #4)
> >> and comm-release
> 
> I have not seen errors in 2.40 and I use it now daily for 4 weeks. Which
> doesn't mean there are non. If the file is there it should be ok for
> comm-release :)
Firefox has it in mozilla-release. And Thunderbird in comm-release (Thunderbird doesn't use comm-release)
Hi Philip,

>> Firefox has it in mozilla-release. And Thunderbird in comm-release 
>> (Thunderbird doesn't use comm-release)

I can't check till Friday if the file is generated in release. LoginManagerContent.jsm was only recently changed for Aurora in bug 1217133 so 2.40 is not affected here. But might be used somewhere else in release.

FRG
http://hg.mozilla.org/releases/comm-release/rev/f30128a10d7f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(philip.chee)
Resolution: --- → FIXED
Assignee: philip.chee → frgrahl
You need to log in before you can comment on or make changes to this bug.