Closed Bug 1231055 Opened 6 years ago Closed 6 years ago

About:plugins is blank

Categories

(Core :: Plug-ins, defect, P1)

Product:
Core
Component:
Plug-ins
Version:
45 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox44 --- unaffected
firefox45 --- verified

People

(Reporter: matthewrbowker.bugs, Assigned: gfritzsche)

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

Fix tags usage in PluginProvider
1.00 KB, patch
mossop
: review+
Details | Diff | Splinter Review 
See full thread at http://comments.gmane.org/gmane.comp.mozilla.nightly/3849.

To reproduce, visit about:plugins in a new tab.  

Last working as of 20151130030228 nightly (see https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=47b49b0d3236&tochange=66a6d7ec9534).
Managed to reproduce it in latest Nightly 45.0a1 (2015-12-07)  
Tried with new profile and in Safe Mode.

Build ID     20151207030210
User Agent   Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0

[bugday-20151207]
Component: Untriaged → Plug-ins
Product: Firefox → Core
I can confirm that the about:plugins page is blank on the latest Nightly 45.0a1 on Mac OS X, Ubuntu 14.04 and Windows 7.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20151207030210
Status: UNCONFIRMED → NEW
Ever confirmed: true
There were no SeaMonkey 2.42a1 nightlies (for any platform, in fact) later than November 30 which might be why this bug hasn't yet hit SeaMonkey:

UA:"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 SeaMonkey/2.42a1" ID:20151130003002 c-c:26610a75105c91f9dca6e14fb2ff97b0d7c8830c m-c:7883e81f3c305078353ca27a6b1adb8c769d5904 en-US

which is the latest SeaMonkey trunk build I can use, is still "good" but IIUC what the reporter said in comment #0 it is probably less than 24h before the culprit change.
I see this JS error when loading the page:

1449619773868	addons.manager	WARN	Exception calling callback: ReferenceError: aTags is not defined (resource://gre/modules/addons/PluginProvider.jsm:452:14)
JS Stack trace:
PluginWrapper.prototype.pluginFullpath@PluginProvider.jsm:452:14 <
filterProperties@AddonManager.jsm:1290:9 <
AddonManagerInternal.requestPlugins/<@AddonManager.jsm:1296:43 <
safeCall@AddonManager.jsm:179:5 <
AddonManagerInternal.getAddonsByTypes/<.noMoreObjects@AddonManager.jsm:2526:9 <
AsyncObjectCaller.prototype.callNext@AddonManager.jsm:375:7 <
AddonManagerInternal.getAddonsByTypes/<.nextObject/<@AddonManager.jsm:2521:11 <
this.Experiments.PreviousExperimentProvider.prototype<.getAddonsByTypes@Experiments.jsm:2264:7 <
callProviderAsync@AddonManager.jsm:254:12 <
AddonManagerInternal.getAddonsByTypes/<.nextObject@AddonManager.jsm:2516:1 <
AsyncObjectCaller.prototype.callNext@AddonManager.jsm:381:7 <
AddonManagerInternal.getAddonsByTypes/<.nextObject/<@AddonManager.jsm:2521:11 <
PluginProvider.getAddonsByTypes@PluginProvider.jsm:153:5 <
callProviderAsync@AddonManager.jsm:254:12 <
AddonManagerInternal.getAddonsByTypes/<.nextObject@AddonManager.jsm:2516:1 <
AsyncObjectCaller.prototype.callNext@AddonManager.jsm:381:7 <
AddonManagerInternal.getAddonsByTypes/<.nextObject/<@AddonManager.jsm:2521:11 <
GMPProvider.getAddonsByTypes@GMPProvider.jsm:668:5 <
callProviderAsync@AddonManager.jsm:254:12 <
AddonManagerInternal.getAddonsByTypes/<.nextObject@AddonManager.jsm:2516:1 <
AsyncObjectCaller.prototype.callNext@AddonManager.jsm:381:7 <
AddonManagerInternal.getAddonsByTypes/<.nextObject/<@AddonManager.jsm:2521:11 <
this.LightweightThemeManager.getAddonsByTypes@LightweightThemeManager.jsm:449:7 <
callProviderAsync@AddonManager.jsm:254:12 <
AddonManagerInternal.getAddonsByTypes/<.nextObject@AddonManager.jsm:2516:1 <
AsyncObjectCaller.prototype.callNext@AddonManager.jsm:381:7 <
AddonManagerInternal.getAddonsByTypes/<.nextObject/<@AddonManager.jsm:2521:11 <
SocialAddonProvider.getAddonsByTypes@SocialService.jsm:1032:7 <
callProviderAsync@AddonManager.jsm:254:12 <
AddonManagerInternal.getAddonsByTypes/<.nextObject@AddonManager.jsm:2516:1 <
AsyncObjectCaller.prototype.callNext@AddonManager.jsm:381:7 <
AddonManagerInternal.getAddonsByTypes/<.nextObject/<@AddonManager.jsm:2521:11 <
this.XPIProvider.getAddonsByTypes/<@XPIProvider.jsm:3953:7 <
makeSafe/<@XPIProviderUtils.js:159:17 <
asyncMap@XPIProviderUtils.js:187:5 <
this.XPIDatabase.getAddonList/<@XPIProviderUtils.js:1083:9 <
Handler.prototype.process@Promise-backend.js:933:23 <
this.PromiseWalker.walkerLoop@Promise-backend.js:812:7 <
Promise*this.PromiseWalker.scheduleWalkerLoop@Promise-backend.js:743:11 <
this.PromiseWalker.schedulePromise@Promise-backend.js:775:7 <
Promise.prototype.then@Promise-backend.js:450:5 <
this.XPIDatabase.getAddonList@XPIProviderUtils.js:1080:5 <
this.XPIDatabase.getVisibleAddons@XPIProviderUtils.js:1163:1 <
this.XPIProvider.getAddonsByTypes@XPIProvider.jsm:3952:5 <
callProviderAsync@AddonManager.jsm:254:12 <
AddonManagerInternal.getAddonsByTypes/<.nextObject@AddonManager.jsm:2516:1 <
AsyncObjectCaller.prototype.callNext@AddonManager.jsm:381:7 <
AsyncObjectCaller@AddonManager.jsm:361:3 <
AddonManagerInternal.getAddonsByTypes@AddonManager.jsm:2514:1 <
this.AddonManager.getAddonsByTypes@AddonManager.jsm:3186:5 <
AddonManagerInternal.requestPlugins@AddonManager.jsm:1295:5 <
MessageListener.prototype.callListeners@RemotePageManager.jsm:35:9 <
RemotePages.prototype.portMessageReceived@RemotePageManager.jsm:108:5 <
MessageListener.prototype.callListeners@RemotePageManager.jsm:35:9 <
ChromeMessagePort.prototype.message@RemotePageManager.jsm:340:3
status-firefox44: --- → unaffected
status-firefox45: --- → affected
Whiteboard: [measurement:client:tracking]
[Tracking Requested - why for this release]:
about:plugins is unusable in Fx45.
tracking-firefox45: --- → ?
This looks like your changeset Tom.
Flags: needinfo?(evilpies)
Never mind, that is a much older change - i'm a bit tired here :)
Flags: needinfo?(evilpies)
Attachment #8696842 - Flags: review?(dtownsend)
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
Today after a long wait there was a new SeaMonkey trunk nightly, and its about:plugins is completely empty:

UA:"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 SeaMonkey/2.42a1" ID:20151209003002 c-c:2c0a9d30510abc917fa16dcd8656a1a186e9d963 m-c:a8965ae93c5d098a4f91ad9da72150bb43df07a7 en-US

Thus I confirm that (as expected) this bug affects also SeaMonkey.
QA Whiteboard: [seamonkey-2.42-affected]
Attachment #8696842 - Flags: review?(dtownsend) → review+
Would be nice to get some tests for this function!
Keywords: checkin-needed
(In reply to Dave Townsend [:mossop] from comment #12)
> Would be nice to get some tests for this function!

True, not this week though.
https://hg.mozilla.org/mozilla-central/rev/64d71638794c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
I hereby VERIFY that the bug is FIXED on the following build of SeaMonkey:

UA:"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 SeaMonkey/2.42a1" ID:20151212003002 c-c:ee0054018a7f3248e625679d80d9111aac25facb m-c:694a530e236564a3d9f4b9fd7d9e96ae782b3a7b en-US

If someone can check it on Firefox, and at least on Linux32 (see comment #1) and on W32 and Mac (see comment #2) then the bug's Status may be set to VERIFIED.
QA Whiteboard: [seamonkey-2.42-affected] → [seamonkey-2.42-verified]
Alexandra, can you verify this?
Flags: needinfo?(alexandra.lucinet)
Priority: -- → P1
QA Contact: alexandra.lucinet
Whiteboard: [measurement:client:tracking] → [measurement:client] [measurement:client:tracking]
I have successfully reproduced this bug with Nightly 45.0a1 (2015-12-07) on Windows 7, 64 Bit!

This Bug's fix is now verified on Latest Nightly on Windows 7!

Build ID 	20151213030241
User Agent 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
(In reply to Hossain Al Ikram [:ikram] (QA Contact) from comment #18)
> I have successfully reproduced this bug with Nightly 45.0a1 (2015-12-07) on
> Windows 7, 64 Bit!
> 
> This Bug's fix is now verified on Latest Nightly on Windows 7!
> 
> Build ID 	20151213030241
> User Agent 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
> Firefox/45.0

This accounts for W32. Anyone on the Mac? And I checked Linux64 on SeaMonkey, but maybe we need to check Linux32 on Firefox?
The issue here was not platform-specific, so i think we are good here. Thanks!
Status: RESOLVED → VERIFIED
status-firefox45: fixed → verified
tracking-firefox45: ? → ---
Flags: needinfo?(alexandra.lucinet)
Works for me.  

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Firefox/45.0 ID:20151213030241 CSet: f07e71078bc8991f74c2101944c8f869c77f442a
Whiteboard: [measurement:client] [measurement:client:tracking] → [measurement:client]
You need to log in before you can comment on or make changes to this bug.