1231066 - Clobber silently failing

Status: RESOLVED INVALID

(Testing Graveyard :: Sisyphus, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: clobber.patch

In Bug 1019626 we enabled always clobber to prevent depends builds issues
and then we noticed build failures due to a missing clobber and added autoclobber=1 in  Bug 1058612

what we missed here is that if clobber had worked like expected Bug 1019626 we would had never to file Bug 1058612, because if we clobber always why:

1. Enable autoclobbering so we don't fail a build just because a clobber is required.

was needed :) 

i found out that this is because need to be changed from

-        buildsteps      = "clobber checkout build"
+        buildsteps      = "checkout clobber build"

to make clobber working again

Comment 1

[Bob Clary [:bc] (inactive)]

I don't understand how this would work. The worker.py calls builder.sh http://hg.mozilla.org/automation/sisyphus/file/tip/bin/builder.sh#l92 which doesn't process the build commands in order. Instead it checks for clean, clobber, checkout then build in that order regardless of the order they are specified on the command line.

clobber checkout build should be identical to checkout clobber build

Comment 2

[Carsten Book [:Tomcat]]

invalid per discussion on irc