1231091 - Remove DecodedStream::IsFinished()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

which doesn't fit into the interface of MediaSink.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb4a913f2228

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1231091. Part 1 - Add mVideoCompleted so MDSM can check when audio/video is done rendering. This removes the only caller of DecodedStream::IsFinished(). r=roc.

Bug 1231091. Part 1 - Add mVideoCompleted so MDSM can check when audio/video is done rendering. This removes the only caller of DecodedStream::IsFinished(). r=roc.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1231091. Part 2 - return correct promises when audio/video track is asked. r=roc.

Bug 1231091. Part 2 - return correct promises when audio/video track is asked. r=roc.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1231091. Part 3 - resolve the end promise when all frames are rendered. r=roc.

Bug 1231091. Part 3 - resolve the end promise when all frames are rendered. r=roc.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1231091. Part 4 - ensure the end promise is resolved in the special case where video duration is 0. r=roc.

Bug 1231091. Part 4 - ensure the end promise is resolved in the special case where video duration is 0. r=roc.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1231091. Part 5 - Remove DecodedStream::IsFinished() and unused code. r=roc.

Bug 1231091. Part 5 - Remove DecodedStream::IsFinished() and unused code. r=roc.

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1231091. Part 6 - fix test_streams_element_capture.html timeout. r=roc.

Bug 1231091. Part 6 - fix test_streams_element_capture.html timeout. r=roc.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8698368 [details]
MozReview Request: Bug 1231091. Part 1 - Add mVideoCompleted so MDSM can check when audio/video is done rendering. This removes the only caller of DecodedStream::IsFinished(). r=roc.

https://reviewboard.mozilla.org/r/27951/#review25563

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8698369 [details]
MozReview Request: Bug 1231091. Part 2 - return correct promises when audio/video track is asked. r=roc.

https://reviewboard.mozilla.org/r/27953/#review25565

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8698370 [details]
MozReview Request: Bug 1231091. Part 3 - resolve the end promise when all frames are rendered. r=roc.

https://reviewboard.mozilla.org/r/27955/#review25567

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8698371 [details]
MozReview Request: Bug 1231091. Part 4 - ensure the end promise is resolved in the special case where video duration is 0. r=roc.

https://reviewboard.mozilla.org/r/27957/#review25569

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8698372 [details]
MozReview Request: Bug 1231091. Part 5 - Remove DecodedStream::IsFinished() and unused code. r=roc.

https://reviewboard.mozilla.org/r/27959/#review25571

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8698373 [details]
MozReview Request: Bug 1231091. Part 6 - fix test_streams_element_capture.html timeout. r=roc.

https://reviewboard.mozilla.org/r/27961/#review25573

Comment 14

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25022e45d6d4
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8a364c7fa79
https://hg.mozilla.org/integration/mozilla-inbound/rev/1aa09d2a3091
https://hg.mozilla.org/integration/mozilla-inbound/rev/24449c2ecee4
https://hg.mozilla.org/integration/mozilla-inbound/rev/8504575868b0
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a1fddc20d91

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/25022e45d6d4
https://hg.mozilla.org/mozilla-central/rev/f8a364c7fa79
https://hg.mozilla.org/mozilla-central/rev/1aa09d2a3091
https://hg.mozilla.org/mozilla-central/rev/24449c2ecee4
https://hg.mozilla.org/mozilla-central/rev/8504575868b0
https://hg.mozilla.org/mozilla-central/rev/3a1fddc20d91