Closed
Bug 1231117
Opened 9 years ago
Closed 9 years ago
Enable xlocale code on DragonFly as well
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
| backlog | parking-lot |
People
(Reporter: jbeich, Assigned: jbeich)
Details
Attachments
(1 file)
It looks like DragonFly supports xlocale API since 3.6. DPorts currently has --disable-webrtc, so I need someone to at least try building mbslen.c standalone on the oldest *supported* release. $ touch csi_platform.h nr_api.h $ cc -I. -D'ABORT(x)=abort()' -c /path/to/mozilla-central/media/mtransport/third_party/nICEr/src/util/mbslen.c http://gitweb.dragonflybsd.org/dragonfly.git?a=search&s=xlocale
Bug 1231117 - Use xlocale on DragonFly as well. r?jesup f?ftigeot@wolfpond.org
Attachment #8696672 -
Flags: review?(rjesup)
Attachment #8696672 -
Flags: feedback?(ftigeot)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8696672 [details] MozReview Request: Bug 1231117 - Use xlocale on DragonFly as well. r?jesup f?ftigeot@wolfpond.org https://reviewboard.mozilla.org/r/27395/#review24847
Attachment #8696672 -
Flags: review?(rjesup) → review+
|
|
||
Updated•9 years ago
|
backlog: --- → parking-lot
Tested myself to not break build on DragonFly 4.5-DEVELOPMENT. Land after bug 1231109 to avoid merge conflicts.
Assignee: nobody → jbeich
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e8bf3603cf74
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Comment 7•8 years ago
|
||
Where can I find this mbslen.c file ?
This was documented in comment 0. Anyway, try $ cd www/firefox $ make patch $ cd $(make -V WRKSRC) $ less media/mtransport/third_party/nICEr/src/util/mbslen.c or just browse https://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/util/mbslen.c
|
|
||
Comment 9•8 years ago
|
||
mbslen.c from firefox-43.0.4 builds without any error on DragonFly 4.5
You need to log in
before you can comment on or make changes to this bug.
Description
•