Closed Bug 1231169 Opened 9 years ago Closed 9 years ago

report rust mp4parse track status in telemetry

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- affected
firefox46 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1229615 added a check reporting rust vs stagefright mp4 track counts for audio and video. This bug is about reporting that info through telemetry so we get some feedback on wild file handling.
WIP patch
Comment on attachment 8696723 [details] [diff] [review]
Report demuxer track comparison in telemetry

It builds! https://treeherder.mozilla.org/#/jobs?repo=try&revision=66dea9c21010&selectedJob=14468911

Adding ally for data peer review. Are you still doing these?
Attachment #8696723 - Flags: review?(kinetik)
Attachment #8696723 - Flags: feedback?(a.m.naaktgeboren)
Attachment #8696723 - Flags: review?(kinetik) → review+
Attachment #8696723 - Flags: feedback?(vladan.bugzilla)
Comment on attachment 8696723 [details] [diff] [review]
Report demuxer track comparison in telemetry

Review of attachment 8696723 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Histograms.json
@@ +6276,5 @@
>    },
> +  "MEDIA_RUST_MP4PARSE_TRACK_MATCH_AUDIO": {
> +    "expires_in_version": "50",
> +    "kind": "boolean",
> +    "description": "(Bug 1231169) Whether rust and stagefight mp4 parser audio track results match.",

put the bug #in a separate bug_numbers field 
add alert_emails fields
Attachment #8696723 - Flags: feedback?(vladan.bugzilla)
Thanks. More like this?

Carrying r=kinetik for media review.
Attachment #8696723 - Attachment is obsolete: true
Attachment #8696723 - Flags: feedback?(a.m.naaktgeboren)
Attachment #8697690 - Flags: review?(vladan.bugzilla)
Comment on attachment 8697690 [details] [diff] [review]
Report demuxer track comparison in telemetry v2

Review of attachment 8697690 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good
Attachment #8697690 - Flags: review?(vladan.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/1526190a14f1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: