Closed Bug 1231175 Opened 10 years ago Closed 10 years ago

The numbers are displayed in reverse

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Version:
45 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- verified

People

(Reporter: over68, Assigned: jfkthame)

References

Details

(Keywords: regression)

Attachments

(3 files)

reduced testcase showing incorrectly reordered digits in bidi text
1.11 KB, text/html
Details
Reftest for failure to recognize mixed directionality in RTL para beginning with number within embed/isolate controls
2.61 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
Missed change from Unicode 6.3 bidi algorithm update (ported from ICU's ubidi): include new ENL and ENR bidi pseudo-types in MASK_LTR
2.31 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
Steps to reproduce: The number is displayed 81 instead of 18 in the page https://dl.dropboxusercontent.com/u/95157096/85f61cf7/lj774qbaxg.html. Actual results: The number is displayed incorrectly. Screenshot https://dl.dropboxusercontent.com/u/95157096/85f61cf7/vp7gru0xdy.png
Flags: needinfo?(jfkthame)
Blocks: 1157727
Keywords: regression
[Tracking Requested - why for this release]: This is a regression that results in incorrect (misleading) display; it can actually corrupt the apparent meaning of the text. If we can't fix it reliably, we should back out bug 1157727 rather than risk shipping this.
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
status-firefox45: --- → affected
tracking-firefox45: --- → ?
Ever confirmed: true
Flags: needinfo?(jfkthame)
Here's a reftest based on the reduced testcase; currently fails.
Attachment #8696873 - Flags: review?(smontagu)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
The problem turned out to be a change that was missed when porting the updates from ICU (see source/common/ubidiimp.h) in bug 1157727. This resulted in us incorrectly considering the text to be a unidirectional RTL run at the end of ResolveExplicitLevels in this example, because DirectionFromFlags didn't recognize the digits as being LTR.
Attachment #8696874 - Flags: review?(smontagu)
Attachment #8696874 - Flags: review?(smontagu) → review+
Attachment #8696873 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8b058539dfd865df1e6c8b01e94992d96df879e Bug 1231175 - Reftest for failure to recognize mixed directionality in RTL para beginning with number within embed/isolate controls. r=smontagu https://hg.mozilla.org/integration/mozilla-inbound/rev/db10960e8ea11debb896e7dcff01d971ef09827f Bug 1231175 - Missed change from Unicode 6.3 bidi algorithm update (ported from ICU's ubidi): include new ENL and ENR bidi pseudo-types in MASK_LTR. r=smontagu
https://hg.mozilla.org/mozilla-central/rev/c8b058539dfd https://hg.mozilla.org/mozilla-central/rev/db10960e8ea1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
tracking-firefox45: ? → ---
QA Whiteboard: [good first verify]
[testday-20160219] Visited website https://dl.dropboxusercontent.com/u/95157096/85f61cf7/lj774qbaxg.html . Number displayed as 18. Bug fix verified.
Marking as verified based on comment 9.
Status: RESOLVED → VERIFIED
status-firefox45: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: