Latest Firefox for iOS release notes URL redirect includes desktop version number

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sgarrity, Assigned: jpetto)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1916274] )

Attachments

(1 attachment)

44 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
In a bedrock template, I'm trying to output a link to the latest Firefox for iOS release notes with the following:

 url('firefox.notes', platform='ios')

This returns a link to /firefox/ios/notes/ (so far so good).

However, that URL then gets redirected to https://www.mozilla.org/en-US/firefox/ios/42.0.2/releasenotes/

(42.0.2 being the latest desktop Firefox release at the time of this writing)

Somewhere there is a redirect affecting the ios release notes that should be limited to the desktop, and an iOS specific redirect setup with the appropriate release version.

Perhaps related to https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/urls.py#L116
(Reporter)

Updated

3 years ago
Whiteboard: [kb=1916274]
(Assignee)

Updated

3 years ago
Assignee: nobody → jon

Comment 1

3 years ago
Last time I checked, there was no latest version of FFiOS in product details, and all links to release notes had to be hard coded.
(Assignee)

Comment 2

3 years ago
Still investigating, but it appears the version returned matches the latest Android release. FirefoxIOS.latest_version [1] is using the same mobile_details method as FirefoxAndroid.latest_version [2]. This mobile_details method maps directly to a product-details JSON file (mobile_details.json [3]), which appears to only refer to Android. I don't see any data in product-details related to iOS builds, which may be the heart of the problem.

[1] https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/firefox_details.py#L277
[2] https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/firefox_details.py#L256
[3] http://viewvc.svn.mozilla.org/vc/libs/product-details/json/mobile_details.json?view=markup
(Assignee)

Comment 3

3 years ago
If we don't have plans to put iOS information into product-details any time soon, perhaps as a fix we can update FirefoxIOS.latest_version [1] to return a value specified in settings? We should do something to rectify that currently broken method.

[1] https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/firefox_details.py#L275

Comment 4

3 years ago
(In reply to Jon Petto [:jpetto] from comment #3)
> If we don't have plans to put iOS information into product-details any time
> soon, perhaps as a fix we can update FirefoxIOS.latest_version [1] to return
> a value specified in settings? We should do something to rectify that
> currently broken method.

That seems like a reasonable near term approach to me.
(Assignee)

Comment 5

3 years ago
Created attachment 8707515 [details] [review]
GitHub PR

Comment 6

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c0191b829b99669b1ae5aefc92440fdd2c7c14c9
[fix bug 1231189] Return correct value from FirefoxIOS.latest_version

https://github.com/mozilla/bedrock/commit/b9871f9c0680d7929e371248d0f2f0e7093328b4
Merge pull request #3770 from jpetto/bug-1231189-fix-fxios-releasenotes-url

[fix bug 1231189] Return correct value from FirefoxIOS.latest_version

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.