1231195 - Startup message > Chrome file doesn't exist: notifyPluginOutdated.png

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Kent James (:rkent)]

From m.d.a.thunderbird:



On 22/11/2015 03:20, ISHIKAWA,chiaki wrote:

>        2 Chrome file doesn't exist: 
> /NREF-COMM-CENTRAL/objdir-tb3/dist/bin/chrome/toolkit/skin/classic/mozapps/plugins/notifyPluginOutdated.png

>        2 Chrome file doesn't exist: 
> /NREF-COMM-CENTRAL/objdir-tb3/dist/bin/chrome/toolkit/skin/classic/mozapps/plugins/notifyPluginBlocked.png

Firefox uses chrome://browser/skin/notification-pluginBlocked.png

SeaMonkey uses chrome://mozapps/skin/plugins/pluginGeneric-16.png
.messageImage[value="blocked-plugins"],
.messageImage[value="carbon-failure-plugins"],
.messageImage[value="disabled-plugins"],
.messageImage[value="missing-plugins"],
.messageImage[value="outdated-plugins"],
.messageImage[value="click-to-play-plugins"],
.messageImage[value="plugin-crashed"] {
  list-style-image:
url("chrome://mozapps/skin/plugins/pluginGeneric-16.png");
}

Phil

Comment 1

[Richard Marti (:Paenglab)]

Attachment: proposed fix

Simple fix using pluginGeneric-16.png instead of the removed files. I could also place the notification-pluginBlocked.png from browser in our tree and point to it. But is this worth the effort for a seldom used function?

Comment 2

[Philip Chee]

> -        iconURL: "chrome://mozapps/skin/plugins/notifyPluginBlocked.png",
> +        iconURL: "chrome://mozapps/skin/plugins/pluginGeneric-16",
Shouldn't this be pluginGeneric-16.png <-- missing extension.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: proposed fix fixed

Yes my bad -> fixed.

Comment 4

[Kent James (:rkent)]

Comment on attachment 8701571 [details] [diff] [review]
proposed fix fixed

This is a little outside of my expertise, and is probably a trivial review for Magnus. Passing to him.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8701571 [details] [diff] [review]
proposed fix fixed

Review of attachment 8701571 [details] [diff] [review]:
-----------------------------------------------------------------

I guess we could have the different icons for different states, but agreed it's not really that crucial.
r=mkmelin

Comment 6

[ISHIKAWA, Chiaki]

(In reply to Richard Marti (:Paenglab) from comment #1)
> But is this worth the effort for a seldom used function?

My original post was concerned with removing confusing error/warning messages as many as possible from the debug build logs so that the log output will become useful.

I am glad to see a patch is finally being proposed and is going to be merged.

Current debug log is full of seemingly grave (yet, may not be indeed) messages
and an uninitiated programmer is overwhelmed with the sheer size of "errors" and "warnings" and can't focus on really important messages. I am trying...

TIA

Comment 7

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/f139b53668d2 -> FIXED

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 8701571 [details] [diff] [review]
proposed fix fixed

[Triage Comment]
Lets take this on the branches too

Comment 9

[Jorg K (CEST = GMT+2)]

Aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/09701bfb9c08

Comment 10

[Kent James (:rkent)]

http://hg.mozilla.org/releases/comm-beta/rev/a37f2f00b6ca