Closed Bug 1231195 Opened 4 years ago Closed 4 years ago

Startup message > Chrome file doesn't exist: notifyPluginOutdated.png

Categories

(Thunderbird :: Theme, defect)

44 Branch
defect
Not set

Tracking

(thunderbird44 fixed, thunderbird45 fixed, thunderbird46 fixed)

RESOLVED FIXED
Thunderbird 46.0
Tracking Status
thunderbird44 --- fixed
thunderbird45 --- fixed
thunderbird46 --- fixed

People

(Reporter: rkent, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

From m.d.a.thunderbird:



On 22/11/2015 03:20, ISHIKAWA,chiaki wrote:

>        2 Chrome file doesn't exist: 
> /NREF-COMM-CENTRAL/objdir-tb3/dist/bin/chrome/toolkit/skin/classic/mozapps/plugins/notifyPluginOutdated.png

>        2 Chrome file doesn't exist: 
> /NREF-COMM-CENTRAL/objdir-tb3/dist/bin/chrome/toolkit/skin/classic/mozapps/plugins/notifyPluginBlocked.png

Firefox uses chrome://browser/skin/notification-pluginBlocked.png

SeaMonkey uses chrome://mozapps/skin/plugins/pluginGeneric-16.png
.messageImage[value="blocked-plugins"],
.messageImage[value="carbon-failure-plugins"],
.messageImage[value="disabled-plugins"],
.messageImage[value="missing-plugins"],
.messageImage[value="outdated-plugins"],
.messageImage[value="click-to-play-plugins"],
.messageImage[value="plugin-crashed"] {
  list-style-image:
url("chrome://mozapps/skin/plugins/pluginGeneric-16.png");
}

Phil
Attached patch proposed fix (obsolete) — Splinter Review
Simple fix using pluginGeneric-16.png instead of the removed files. I could also place the notification-pluginBlocked.png from browser in our tree and point to it. But is this worth the effort for a seldom used function?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8701439 - Flags: review?(rkent)
> -        iconURL: "chrome://mozapps/skin/plugins/notifyPluginBlocked.png",
> +        iconURL: "chrome://mozapps/skin/plugins/pluginGeneric-16",
Shouldn't this be pluginGeneric-16.png <-- missing extension.
Flags: needinfo?(richard.marti)
Yes my bad -> fixed.
Attachment #8701439 - Attachment is obsolete: true
Attachment #8701439 - Flags: review?(rkent)
Flags: needinfo?(richard.marti)
Attachment #8701571 - Flags: review?(rkent)
Comment on attachment 8701571 [details] [diff] [review]
proposed fix fixed

This is a little outside of my expertise, and is probably a trivial review for Magnus. Passing to him.
Attachment #8701571 - Flags: review?(rkent) → review?(mkmelin+mozilla)
Comment on attachment 8701571 [details] [diff] [review]
proposed fix fixed

Review of attachment 8701571 [details] [diff] [review]:
-----------------------------------------------------------------

I guess we could have the different icons for different states, but agreed it's not really that crucial.
r=mkmelin
Attachment #8701571 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
(In reply to Richard Marti (:Paenglab) from comment #1)
> But is this worth the effort for a seldom used function?

My original post was concerned with removing confusing error/warning messages as many as possible from the debug build logs so that the log output will become useful.

I am glad to see a patch is finally being proposed and is going to be merged.

Current debug log is full of seemingly grave (yet, may not be indeed) messages
and an uninitiated programmer is overwhelmed with the sheer size of "errors" and "warnings" and can't focus on really important messages. I am trying...

TIA
https://hg.mozilla.org/comm-central/rev/f139b53668d2 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Comment on attachment 8701571 [details] [diff] [review]
proposed fix fixed

[Triage Comment]
Lets take this on the branches too
Attachment #8701571 - Flags: approval-comm-beta+
Attachment #8701571 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.