1231200 - Add [*:error] prefix to error messages from shell scripts for firefox desktop tasks

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

This prefix causes messages to show up in the treeherder summary

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

In both build-linux.sh and test-linux.sh (and associated scripts).

Things to pay particular attention to:

 * if the curl invocation to download mozharness.zip fails, give a good error
 * if xvfb startup fails, give a good error

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a92d5fa696f

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=818080f9af2c

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

  https://tools.taskcluster.net/task-inspector/#b7cjj3mASpiYVvcB3gulvg/0
had an intentional error, and it didn't show up here:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=063e1729fe14&selectedJob=17916391

so clearly I'm missing something..

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1231200: produce treeherder-compatible errors; r?jmaher

Review commit: https://reviewboard.mozilla.org/r/39309/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39309/

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8729245 [details]
MozReview Request: Bug 1231200: produce treeherder-compatible errors; r?jmaher

https://reviewboard.mozilla.org/r/39309/#review36023

I like this.  one concern is that the errors might need to be massaged to work better with treeherder error matching- for now, lets see what shows up as this is a big win.

::: testing/taskcluster/scripts/builder/build-linux.sh:85
(Diff revision 1)
> +    if [ $xvfb_test == 255 ]; then fail "xvfb did not start properly"; fi

are there other failure conditions of xvfb?

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

> are there other failure conditions of xvfb?

I'm sure there are :)

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

if there are obvious ones, lets get it in now, otherwise we can address them when we see them.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/614920a68d55

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/614920a68d55