Add [*:error] prefix to error messages from shell scripts for firefox desktop tasks

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Details

Attachments

(1 attachment)

This prefix causes messages to show up in the treeherder summary
In both build-linux.sh and test-linux.sh (and associated scripts).

Things to pay particular attention to:

 * if the curl invocation to download mozharness.zip fails, give a good error
 * if xvfb startup fails, give a good error
  https://tools.taskcluster.net/task-inspector/#b7cjj3mASpiYVvcB3gulvg/0
had an intentional error, and it didn't show up here:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=063e1729fe14&selectedJob=17916391

so clearly I'm missing something..
Flags: needinfo?(wkocher)
Comment on attachment 8729245 [details]
MozReview Request: Bug 1231200: produce treeherder-compatible errors; r?jmaher

https://reviewboard.mozilla.org/r/39309/#review36023

I like this.  one concern is that the errors might need to be massaged to work better with treeherder error matching- for now, lets see what shows up as this is a big win.

::: testing/taskcluster/scripts/builder/build-linux.sh:85
(Diff revision 1)
> +    if [ $xvfb_test == 255 ]; then fail "xvfb did not start properly"; fi

are there other failure conditions of xvfb?
Attachment #8729245 - Flags: review?(jmaher) → review+
> are there other failure conditions of xvfb?

I'm sure there are :)
if there are obvious ones, lets get it in now, otherwise we can address them when we see them.

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/614920a68d55
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Flags: needinfo?(wkocher)
Component: Integration → Services
You need to log in before you can comment on or make changes to this bug.