1231210 - Options Icon Touches Search Box on New Tab Page Tiles View

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, defect)

Description

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: Screen Shot 2015-12-08 at 4.26.55 PM.png

New Tab preferences cog overlaps the search box in new tab view when window is adjusted to be same width as search box.

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

mozregress this and see if it's an old bug or not

Comment 2

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: Expected Behavior in 34.0a1 (2014-08-15)

Comment 3

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

10:22.48 LOG: MainThread Bisector INFO Narrowed nightly regression window from [2014-08-13, 2014-08-16] (3 days) to [2014-08-15, 2014-08-16] (1 days) (~0 steps left)
10:22.48 LOG: MainThread main INFO Got as far as we can go bisecting nightlies...
10:22.48 LOG: MainThread Bisector INFO Last good revision: c9f8cc9ce89c (2014-08-15)
10:22.48 LOG: MainThread Bisector INFO First bad revision: 053a96e40244 (2014-08-16)

Looks like this is where it was introduced.

Comment 4

[:Gijs (he/him)]

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c9f8cc9ce89c&tochange=053a96e40244

Kind of looks like bug 1026561 but that got backed out. :-\

Then there's bug 1041678 but that shouldn't have changed layout in any way, ditto for https://hg.mozilla.org/mozilla-central/rev/3031346b1104 (bug 1050447).

Ed, can you take a look?

Comment 5

[Ed Lee :Mardak]

The regression range wasn't quite right probably because it depends on the new tab page having enough tiles to cause scrollbars. It looks like bug 1158859 caused the issue when the customize button was moved down/left from where it was before:

 #newtab-customize-button {
   position: absolute;
-  top: 6px;
-  right: 6px;
+  top: 10px;
+  right: 20px;

Comment 6

[Jessilyn Davis]

Hello!

This bug has been closed due to inactivity and/or the potential for this bug to no longer be an issue with the new Discovery Stream-powered New Tab experience.

Please help us triage by reopening if this issue still persists and should be addressed.

Thanks!

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.