Closed Bug 1231245 Opened 4 years ago Closed 4 years ago

LayersLogging code needs updating for typed Matrix4x4

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Bug 1069417 changed Matrix4x4 to be a typedef for Matrix4x4Typed<UnknownUnits, UnknownUnits> but the code in LayersLogging.h wasn't templated, so it doesn't work for Matrix4x4 expansions with other units. Patch forthcoming.
Attached patch PatchSplinter Review
#include'ing Matrix.h was needed since the function needs |Matrix|.
Attachment #8696846 - Flags: review?(botond)
Comment on attachment 8696846 [details] [diff] [review]
Patch

Review of attachment 8696846 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Sorry for forgetting about this when introducing Matrix4x4Typed.

::: gfx/layers/LayersLogging.h
@@ +184,5 @@
>  void
>  AppendToString(std::stringstream& aStream, const mozilla::gfx::Matrix& m,
>                 const char* pfx="", const char* sfx="");
>  
> +template<class T, class U> void

nits:
  - class SourceUnits, class TargetUnits
  - elsewhere the template parameter list and return type go on separate lines
Attachment #8696846 - Flags: review?(botond) → review+
Fixed nits and landed ^

Also for the record try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=71fc91303e34 includes the updated patch
https://hg.mozilla.org/mozilla-central/rev/e14b7deb2fda
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.