Remove lots of unused parameters, mostly in layout/xul/

RESOLVED FIXED in Firefox 46

Status

()

Core
Layout
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks: 1 bug)

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(11 attachments)

44.36 KB, patch
roc
: review+
Details | Diff | Splinter Review
6.20 KB, patch
jld
: review+
Details | Diff | Splinter Review
2.26 KB, patch
roc
: review+
Details | Diff | Splinter Review
1.41 KB, patch
jfkthame
: review+
Details | Diff | Splinter Review
1.22 KB, patch
vlad
: review+
Details | Diff | Splinter Review
3.59 KB, patch
roc
: review+
Details | Diff | Splinter Review
7.13 KB, patch
roc
: review+
Details | Diff | Splinter Review
3.05 KB, patch
roc
: review+
Details | Diff | Splinter Review
2.29 KB, patch
roc
: review+
Details | Diff | Splinter Review
4.38 KB, patch
roc
: review+
Details | Diff | Splinter Review
1.30 KB, patch
terrence
: review+
Details | Diff | Splinter Review
I've been fiddling with -Wunused-parameter. Here are some things I've found with it.
Created attachment 8696857 [details] [diff] [review]
(part 1) - Remove unused nsBoxLayoutState parameters from many functions
Attachment #8696857 - Flags: review?(roc)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Created attachment 8696858 [details] [diff] [review]
(part 2) - Remove unused BlobDirState parameters from SetLazyData()
Attachment #8696858 - Flags: review?(jld)
Created attachment 8696859 [details] [diff] [review]
(part 3) - Remove unused parameter from TryToOuterize()
Attachment #8696859 - Flags: review?(roc)
Created attachment 8696860 [details] [diff] [review]
(part 4) - Remove dead SetContext() declaration
Attachment #8696860 - Flags: review?(jfkthame)
Created attachment 8696862 [details] [diff] [review]
(part 5) - Remove dead FromCSSPerspectiveInfo() function
Attachment #8696862 - Flags: review?(vladimir)
Created attachment 8696863 [details] [diff] [review]
(part 6) - Remove unused parameter from Damage functions
Attachment #8696863 - Flags: review?(roc)
Created attachment 8696864 [details] [diff] [review]
(part 7) - Remove unused parameters from two layout functions
Attachment #8696864 - Flags: review?(roc)
Created attachment 8696865 [details] [diff] [review]
(part 9) - Remove unused parameter from ShowPopup()
Attachment #8696865 - Flags: review?(roc)
Created attachment 8696866 [details] [diff] [review]
(part 10) - Remove unused parameters from StartAPZDrag()
Attachment #8696866 - Flags: review?(roc)
Created attachment 8696867 [details] [diff] [review]
(part 11) - Remove unused parameter from HidePopupsInList()
Attachment #8696867 - Flags: review?(roc)
Attachment #8696860 - Flags: review?(jfkthame) → review+
Comment on attachment 8696858 [details] [diff] [review]
(part 2) - Remove unused BlobDirState parameters from SetLazyData()

Review of attachment 8696858 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and I tracked this to bug 1177688 where nobody said anything about it, so I'm assuming it's as safe to remove as it looks.
Attachment #8696858 - Flags: review?(jld) → review+
Created attachment 8697140 [details] [diff] [review]
(part 12) - Remove TraceableVectorOperations::canAppendWithoutRealloc

It's unused.
Attachment #8697140 - Flags: review?(terrence)
Attachment #8697140 - Flags: review?(terrence) → review+
Comment on attachment 8696859 [details] [diff] [review]
(part 3) - Remove unused parameter from TryToOuterize()

Review of attachment 8696859 [details] [diff] [review]:
-----------------------------------------------------------------

not my area, but trivial
Attachment #8696859 - Flags: review?(roc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/182171efdc63a30529e7568a2215caa637fb4df0
Bug 1231256 (part 1) - Remove unused nsBoxLayoutState parameters from many functions. r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/62a5376b5872f56e6ca5f066707e9a51bb6f3cac
Bug 1231256 (part 2) - Remove unused BlobDirState parameters from SetLazyData(). r=jld.

https://hg.mozilla.org/integration/mozilla-inbound/rev/812c6950a3013d79064bf1e9048da4d9b57e2b7f
Bug 1231256 (part 3) - Remove unused parameter from TryToOuterize(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/38d815a88e45c302bdfa7b62538cb59ce9c77518
Bug 1231256 (part 4) - Remove dead SetContext() declaration. r=jfkthame.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ff479c4c0ccf2a8a3a35f45f3212115e4edfc82
Bug 1231256 (part 6) - Remove unused parameter from Damage functions. r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/721bc6e718a829a61a2fe407d48c04e7d47fce40
Bug 1231256 (part 7) - Remove unused parameters from two layout functions. r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8fe4c23ba7ee936a77e751f973bc8bc86b51ba9
Bug 1231256 (part 8) - Remove unused parameters from MouseClicked(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c96cf4a9adf4c153d4c3d117382b6a2e55b60035
Bug 1231256 (part 9) - Remove unused parameter from ShowPopup(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb400f0cd3f355c9d4dafd5b1461e9bedf086c41
Bug 1231256 (part 10) - Remove unused parameters from StartAPZDrag(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1a84550d4259710c073ed6202821c4715c230b4
Bug 1231256 (part 11) - Remove unused parameter from HidePopupsInList(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0bcfe60c2977a6a0c93275aff8382a18677311ae
Bug 1231256 (part 12) - Remove TraceableVectorOperations::canAppendWithoutRealloc. r=terrence.
Still waiting on r+ for part 5.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 18

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5351257556f0
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
Blocks: 1232547
No longer depends on: 1232547
You need to log in before you can comment on or make changes to this bug.