1231340 - Can't use 'defined(@array)'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Antoine Raquin]

Attachment: .userconfig

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150305021524

Steps to reproduce:

I cloned the B2G repo (git clone git://github.com/mozilla-b2g/B2G.git) and did ./configure flame-kk. It downloaded as expected.

According to this https://developer.mozilla.org/en-US/Firefox_OS/Firefox_OS_build_prerequisites#Arch_Linux I copy/pasted the pacman downloads. yaourt told me libxml2-utils was not found. I still have libxml2 and lib32-libxml2.

I set the ccache capacity at 10 GB and configured udev as required.

Then I downloaded virtualenvwrapper. Here is the output : http://pastebin.com/MCm0Ytjp

Then I plugged my phone to my computer and did "./build.sh".

I've put my .userconfig as an attachement.


Actual results:

I've got the following message : http://pastebin.com/qRJkWtbL

I think the important thing is the following string of text :

Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at /home/antoine/git/B2G/kernel/kernel/timeconst.pl line 373.
make[3]: *** [kernel/timeconst.h] Error 255
make[2]: *** [kernel] Error 2
make[1]: *** [sub-make] Error 2
make[1]: Leaving directory `/home/antoine/git/B2G/kernel'
make: *** [out/target/product/flame/obj/KERNEL_OBJ/arch/arm/boot/zImage] Error 2


Expected results:

Firefox OS would've been compiled and would be running on my phone.

Comment 1

[Gabriele Svelto [:gsvelto]]

Confirmed, just hit this during my morning build of the flame.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Workaround patch

Here's a quick workaround that worked for me. cd into the kernel directory, apply it and then resume your build.

Comment 3

[Antoine Raquin]

Hello, I'm sorry, I'm very bad at programming. I tried to run it but I only get error messages related to the syntax, is it bash code ?

With all my apologies.

Comment 4

[Gabriele Svelto [:gsvelto]]

If you want to apply the patch do the following:

- Save the contents of attachment 8696990 [details] [diff] [review] to a file (let's call it wip.patch)
- From your B2G source directory go in the the kernel directory: cd kernel
- Apply the patch: patch -p1 < wip.patch
- Resume building with build.sh, stuff should work this time

Comment 5

[Antoine Raquin]

Ok, thanks ! I have work to do, I'll try this later.

Have a nice day !

Comment 6

[Gabriele Svelto [:gsvelto]]

Taking this bug since I've found the proper way to fix it.

Comment 7

[Gabriele Svelto [:gsvelto]]

Attachment: Upstream patch

This is the upstream patch that fixes the problem, asking for review just to get a thumbs up that this is the best way to fix it (I think it is but I've never cherry picked a patch from the vanilla kernel before and I'm not sure if we have a policy about it or not).

Comment 8

[Michael Wu [:mwu]]

Comment on attachment 8697580 [details] [diff] [review]
Upstream patch

Straight cherry picks are fine. Just don't want to lose commit and attribution info.

Comment 9

[Gabriele Svelto [:gsvelto]]

Excellent, I've taken the original unmodified patch with attribution and all and I'll push it into our repo.

Comment 10

[Gabriele Svelto [:gsvelto]]

Pushed to codeaurora_kernel_msm/t2m-flame-3.4-kk 1e562fa3ac618fe136d3515bb14a070b4153e0cd

https://github.com/mozilla-b2g/codeaurora_kernel_msm/commit/1e562fa3ac618fe136d3515bb14a070b4153e0cd

Comment 11

[Antoine Raquin]

Hello, I have another bug. I tried to solve it by myself but I didn't find any solution. It may be related to your script.

I put the bug in plain text here so other users can find it :

##################################################

  File "build/tools/findleaves.py", line 95
    print r
          ^
SyntaxError: Missing parentheses in call to 'print'
  File "build/tools/diff_package_overlays.py", line 88
    print r
          ^
SyntaxError: Missing parentheses in call to 'print'
No private recovery resources for TARGET_DEVICE flame
build/tools/generate-notice-files.py  out/target/product/flame/obj/NOTICE.txt  out/target/product/flame/obj/NOTICE.html "Notices for files contained in the filesystem images in this directory:" out/target/product/flame/obj/NOTICE_FILES/src
  File "build/tools/generate-notice-files.py", line 43
    except getopt.GetoptError, err:
                             ^
SyntaxError: invalid syntax
make: *** [out/target/product/flame/obj/NOTICE.html] Error 1

real    0m2.097s
user    0m1.087s
sys     0m0.317s

##################################################

Thanks for your help, I hope this will help other users. Have a nice evening :)

Comment 12

[Gabriele Svelto [:gsvelto]]

Sounds like you're running Python 3, you need to use Python 2 for the build. Anyway if you encounter this with Python 2 then please file another bug.

Comment 13

[Antoine Raquin]

Thanks. I'm sorry, I had sourced the virtualenvwrapper script from a random repository. I don't know this command well. I'm sorry.

My build ran fine then, thanks a lot !