1231351 - [Static Analysis][Operands don't affect result] In function ConvertWOFF2ToSFNT from woff2.cc - unnecessary code removal

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that expression will never be valid:

>> if (compressed_length > std::numeric_limits<uint32_t>::max()) {
>>    return OTS_FAILURE();
>>  }

since type of compressed_length is:

>> uint32_t compressed_length;

it's obvious it cannot hold a number greater than 2^32. I suggest removing the if statement.

Comment 1

[Andi [:andi]]

Attachment: Bug 1231351.diff

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This should probably be reported directly upstream to OTS

Comment 3

[Andi [:andi]]

this patch is no longer needed since the new framework for OTS is used and this is obsolete.