Status

Firefox OS
Gaia::Clock
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We need to move Clock to L20n.

Comment 1

2 years ago
Created attachment 8696983 [details] [review]
[gaia] zbraniecki:1231354-move-clock-to-l20n > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Assignee: nobody → gandalf
(Assignee)

Comment 2

2 years ago
Comment on attachment 8696983 [details] [review]
[gaia] zbraniecki:1231354-move-clock-to-l20n > mozilla-b2g:master

Hi Marcus,

We're deprecating l10n.js in favor of l20n.js - I'd like to move all apps to L20n in 2.6 cycle.

The patch if fairly trivial, so I hope you'll like it :)
Attachment #8696983 - Flags: review?(m)
(Assignee)

Comment 3

2 years ago
No perf diff:

Clock, runs=31, flame-kk:

master:
| Metric                | Mean     | Median | Min    | Max    | StdDev | 95% Bound |
| --------------------- | -------- | ------ | ------ | ------ | ------ | --------- |
| navigationLoaded      | 790.581  | 784    | 741    | 994    | 40.838 | 804.957   |
| navigationInteractive | 913.452  | 909    | 865    | 1127   | 42.575 | 928.439   |
| visuallyLoaded        | 1100.742 | 1091   | 1041   | 1280   | 41.886 | 1115.487  |
| contentInteractive    | 1101.032 | 1091   | 1042   | 1280   | 41.853 | 1115.765  |
| fullyLoaded           | 1101.290 | 1091   | 1042   | 1280   | 41.909 | 1116.043  |
| uss                   | 15.003   | 15.016 | 14.484 | 15.090 | 0.098  | 15.038    |
| pss                   | 19.504   | 19.522 | 19.019 | 19.585 | 0.092  | 19.536    |
| rss                   | 34.730   | 34.742 | 34.266 | 34.805 | 0.088  | 34.761    |

l20n:
| Metric                | Mean     | Median | Min    | Max    | StdDev | 95% Bound |
| --------------------- | -------- | ------ | ------ | ------ | ------ | --------- |
| navigationLoaded      | 778.355  | 774    | 740    | 887    | 26.765 | 787.777   |
| navigationInteractive | 901.419  | 898    | 860    | 1022   | 29.092 | 911.661   |
| visuallyLoaded        | 1103.452 | 1095   | 1055   | 1242   | 35.210 | 1115.846  |
| contentInteractive    | 1103.742 | 1095   | 1055   | 1243   | 35.252 | 1116.152  |
| fullyLoaded           | 1104     | 1096   | 1056   | 1243   | 35.142 | 1116.371  |
| pss                   | 19.591   | 19.608 | 19.090 | 19.700 | 0.106  | 19.628    |
| uss                   | 15.101   | 15.109 | 14.578 | 15.191 | 0.100  | 15.137    |
| rss                   | 34.815   | 34.828 | 34.301 | 34.918 | 0.097  | 34.849    |
Attachment #8696983 - Flags: review?(m) → review+
(Assignee)

Comment 4

2 years ago
Commit: https://github.com/mozilla-b2g/gaia/commit/e8fc98d53e7e98bb6fd04c56e5f7f644b19d6b18
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

2 years ago
Nice 400kb win on USS on Flame-kk according to raptor.mozilla.org :)
(Assignee)

Comment 6

2 years ago
Also, once bug 1231468 lands there may be a perf win.
You need to log in before you can comment on or make changes to this bug.