Open Bug 1231368 Opened 4 years ago Updated 6 months ago

Reassigning alerts doesn't check for errors

Categories

(Tree Management :: Perfherder, defect, P5)

defect

Tracking

(Not tracked)

People

(Reporter: wlach, Unassigned)

Details

(Whiteboard: perfherder-starter-bug, [lang=js])

In bug 1228156, we added support for reassigning alerts, but we don't currently check for errors. The fact that:

(1) We require the user to be logged in to perform this operation
(2) We validate the form input before submitting

... should mean that this will work in 99% of cases, but there are still possible failure modes:

(1) The user specifies an invalid revised summary id
(2) Network error

You can see an example of where we throw an error after this type of operation fails here:

https://github.com/mozilla/treeherder/blob/cbd32a4/ui/js/controllers/perf/graphs.js#L575
The file to modify is ui/js/controllers/perf/alerts.js
Priority: -- → P5
Whiteboard: perfherder-starter-bug → perfherder-starter-bug, [lang=js]
You need to log in before you can comment on or make changes to this bug.