Open
Bug 1231384
Opened 9 years ago
Updated 2 years ago
Make kFlagsTable use 64-bit fields
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox45 | --- | affected |
People
(Reporter: dholbert, Unassigned)
Details
Attachments
(1 file)
2.06 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•9 years ago
|
||
[sorry, accidentally hit 'enter' when typing summary. I wish I could disable bugzilla's "submit" behavior when I do that] Bug 1230701 added the 1<<30 flag bit to nsCSSProps' kFlagsTable. We have 1 bit left (1u << 30), after which we'll need to increase the size of the flag fields in kFlagsTable to 64-bits if we want to add any more flags.
Summary: Make kFlagsTable → Make kFlagsTable use 64-bit fields
Reporter | ||
Comment 2•9 years ago
|
||
(We don't need to take this patch quite yet, but we may need to do so soon.)
Reporter | ||
Comment 3•9 years ago
|
||
<tangent> (BTW: I filed this because I initially misread a build warning about a flag that I'm adding in bug 1208344, with value 1<<31. Turns out that flag value (for the highest-order bit) is basically-fine & doesn't need this bug, but to avoid a build warning, I just needed to specify the flag value as 1u<<31 (with a "u") or else the compiler complains about storing -infinity in a _u_int32. After that bit is added, though, we'll need this bug (to increase the number of bits) if we want any more flags. </tangent>
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•