1231425 - Move Camera to L20n

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

We're deprecating l10n.js and moving all apps to l20n.js.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1231425-move-camera-to-l20n > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8697045 [details] [review]
[gaia] zbraniecki:1231425-move-camera-to-l20n > mozilla-b2g:master

Hi Wilson, can you review the patch?

I removed some guards on `localize` functions since everything is async now and we don't need to wait for localization to be ready.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

perf tests flame-kk, RUNS=31:

master:
| Metric                | Mean     | Median | Min    | Max    | StdDev | 95% Bound |
| --------------------- | -------- | ------ | ------ | ------ | ------ | --------- |
| navigationLoaded      | 1230.516 | 1234   | 1158   | 1291   | 28.063 | 1240.395  |
| navigationInteractive | 1230.903 | 1235   | 1158   | 1291   | 28.038 | 1240.773  |
| visuallyLoaded        | 1421.258 | 1422   | 1346   | 1466   | 29.166 | 1431.525  |
| contentInteractive    | 1862.032 | 1855   | 1793   | 1937   | 33.461 | 1873.811  |
| fullyLoaded           | 1879.581 | 1872   | 1810   | 1953   | 33.651 | 1891.427  |
| uss                   | 12.828   | 12.832 | 12.766 | 12.902 | 0.033  | 12.839    |
| pss                   | 17.017   | 17.022 | 16.955 | 17.093 | 0.034  | 17.029    |
| rss                   | 32.811   | 32.816 | 32.742 | 32.887 | 0.034  | 32.823    |

l20n:
| Metric                | Mean     | Median | Min    | Max    | StdDev | 95% Bound |
| --------------------- | -------- | ------ | ------ | ------ | ------ | --------- |
| navigationLoaded      | 1230.323 | 1220   | 1171   | 1299   | 31.472 | 1241.401  |
| navigationInteractive | 1230.742 | 1221   | 1172   | 1299   | 31.389 | 1241.792  |
| visuallyLoaded        | 1389.903 | 1378   | 1343   | 1466   | 30.882 | 1400.775  |
| contentInteractive    | 1862.581 | 1853   | 1782   | 1960   | 44.410 | 1878.214  |
| fullyLoaded           | 1879.258 | 1873   | 1794   | 1973   | 44.513 | 1894.928  |
| uss                   | 12.865   | 12.848 | 12.738 | 13.145 | 0.077  | 12.892    |
| pss                   | 17.053   | 17.037 | 16.927 | 17.339 | 0.079  | 17.081    |
| rss                   | 32.829   | 32.809 | 32.703 | 33.109 | 0.080  | 32.857    |

Comment 4

[Wilson Page [:wilsonpage]]

Comment on attachment 8697045 [details] [review]
[gaia] zbraniecki:1231425-move-camera-to-l20n > mozilla-b2g:master

Sweet, thanks Zibi!

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks!

commit: https://github.com/mozilla-b2g/gaia/commit/4dc550401b196fa824e11738bdd18387b73226b8