Closed Bug 1231552 Opened 4 years ago Closed 4 years ago

backout Proxy: Firefox fallback to regular connection

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox44 --- fixed
firefox45 --- fixed

People

(Reporter: bagder, Assigned: bagder)

Details

Attachments

(1 file, 1 obsolete file)

Backout the changes for these bugs 

   Bug 1207798 - add pref to toggle proxy behavior when inaccessible. r=mcmanus
   Bug 1214200: avoid double NS_RELEASE(), r=mcmanus
   Bug 1121800 -  when all proxies fail try DIRECT, r=mcmanus

This will instead be handled as a slightly larger take in bug 1230803
Assignee: nobody → daniel
Status: NEW → ASSIGNED
Attachment #8697127 - Flags: review+
Keywords: checkin-needed
Comment on attachment 8697127 [details] [diff] [review]
0001-Bug-1231552-Back-out-bug-1121800-bug-1207798-and-bug.patch

Approval Request Comment
[Feature/regressing bug #]: 1121800 and 1207798 
[User impact if declined]: changes proxy behavior in undesired ways, possibly leaking information 
[Describe test coverage new/current, TreeHerder]: lacking
[Risks and why]: the backout should be very small risk
[String/UUID change made/needed]:
Attachment #8697127 - Flags: approval-mozilla-aurora?
hi, this failed to apply:

applying 0001-Bug-1231552-Back-out-bug-1121800-bug-1207798-and-bug.patch
patching file modules/libpref/init/all.js
Hunk #1 FAILED at 1824
1 out of 1 hunks FAILED -- saving rejects to file modules/libpref/init/all.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1231552-Back-out-bug-1121800-bug-1207798-and-bug.patch
Flags: needinfo?(daniel)
Keywords: checkin-needed
Rebased, take 2.

The all.js file is a bit sensitive to modify as it is quite a popular thing... =)
Attachment #8697127 - Attachment is obsolete: true
Attachment #8697127 - Flags: approval-mozilla-aurora?
Flags: needinfo?(daniel)
Attachment #8697265 - Flags: review+
Keywords: checkin-needed
Comment on attachment 8697265 [details] [diff] [review]
v2-0001-Bug-1231552-Back-out-bug-1121800-bug-1207798-and-.patch

Approval Request Comment
[Feature/regressing bug #]: Primarily the fix for bug 1121800
[User impact if declined]: We introduce a changed behavior that some people object to, due to the risk of leaking network information
[Describe test coverage new/current, TreeHerder]: lacking
[Risks and why]: just a reversion of three patches, low risk
[String/UUID change made/needed]:
Attachment #8697265 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/e8b02a6a50d2 - landed 15 hours ago.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Sylvestre, we need to revert these patches in Aurora soon so we are safer by default and not bypassing proxy unless explicitly told/pref'd to do so (coming in a new fix). Could you please approve the Aurora uplift?
Flags: needinfo?(sledru)
Comment on attachment 8697265 [details] [diff] [review]
v2-0001-Bug-1231552-Back-out-bug-1121800-bug-1207798-and-.patch

Sure, sorry, I was waiting for aurora update to be enabled!
Flags: needinfo?(sledru)
Attachment #8697265 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tomcat, Wes: Please help land in m-a. Thanks!
Flags: needinfo?(wkocher)
Flags: needinfo?(cbook)
These backouts landed in 45, which is what is now currently on aurora. Does this actually need to go to 44 (beta) instead?
Flags: needinfo?(wkocher) → needinfo?(rkothari)
Let's ask Daniel. Is this a backout patch for 45 or 44? Please let us know.
Flags: needinfo?(rkothari)
Flags: needinfo?(daniel)
Flags: needinfo?(cbook)
When I requested this, aurora was still 44. It has now turned into beta.

The two commits that are still in beta that should get backed out to align it with this bug and the state in m-i:

https://hg.mozilla.org/releases/mozilla-beta/rev/13db8516d365
https://hg.mozilla.org/releases/mozilla-beta/rev/a62a3c113e40

The latter being a single-line fix of the first commit.

(bug 1207798 clearly never landed in 44)
Flags: needinfo?(daniel)
Comment on attachment 8697265 [details] [diff] [review]
v2-0001-Bug-1231552-Back-out-bug-1121800-bug-1207798-and-.patch

Approval Request Comment
See the earlier aurora approval request.
Attachment #8697265 - Flags: approval-mozilla-aurora+ → approval-mozilla-beta?
Comment on attachment 8697265 [details] [diff] [review]
v2-0001-Bug-1231552-Back-out-bug-1121800-bug-1207798-and-.patch

We need to back this out from FF44, Beta+
Attachment #8697265 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.