Log raw packet instead of stringified commands and responses in Marionette server

RESOLVED FIXED in Firefox 46

Status

Testing
Marionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({ateam-marionette-server})

unspecified
mozilla46
ateam-marionette-server
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We currently log the stringification of Command and Response in the Marionette server

For implementors and debugging it’s more useful to dump the raw packets in Dispatcher#log_.  This can be achieved by calling toMsg rather than toString.

Relevant pointers:

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/dispatcher.js?from=marionette%2Fdispatcher.js#238
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/message.js?from=marionette%2Fmessage.js#133
(Assignee)

Updated

2 years ago
Keywords: ateam-marionette-server
Whiteboard: [good first bug][lang=js]
(Assignee)

Updated

2 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Whiteboard: [good first bug][lang=js]
(Assignee)

Comment 1

2 years ago
Created attachment 8705703 [details]
MozReview Request: Bug 1231660 - Log raw packet instead of stringified messages in Marionette server; r?AutomatedTester

Implementors and users find it better if we log the actual sent
and received packets, rather than a stringification of the messages
representing them.

Review commit: https://reviewboard.mozilla.org/r/30149/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30149/
Attachment #8705703 - Flags: review?(dburns)
Comment on attachment 8705703 [details]
MozReview Request: Bug 1231660 - Log raw packet instead of stringified messages in Marionette server; r?AutomatedTester

https://reviewboard.mozilla.org/r/30149/#review27101
Attachment #8705703 - Flags: review?(dburns) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2dba9904b0ff
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.