1231677 - [Static Analysis][Unchecked return value] In function MulticastDNSDeviceProvider::ForceDiscovery from MulticastDNSDeviceProvider.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that return value from mDiscoveryTimer->Init() is not checked. As it can bee seen from the code if that functions fails a waning message will be triggered:

>>  if (mIsDiscovering) {
>>    Unused << mDiscoveryTimer->Cancel();
>>
>>    NS_WARN_IF(NS_FAILED(mDiscoveryTimer->Init(this,
>>                                               mDiscveryTimeoutMs,
>>                                               nsITimer::TYPE_ONE_SHOT)));
>>    return NS_OK;
>>  }

Since the mDiscoveryTimer->Init function fails, i think we should also return the error code and stop the execution of the function and return to: MulticastDNSDeviceProvider::Init()

The code that i'm referring to, that verifies the status of ForceDiscovery is:
 
>>  Unused << mPresentationServer->SetId(mServiceName);
>>
>>  if (mDiscoveryEnabled && NS_WARN_IF(NS_FAILED(rv = ForceDiscovery()))) {
>>    return rv;
>>  }

Comment 1

[Andi [:andi]]

Attachment: Bug 1231677.diff

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/094fd5a4d3dc

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/094fd5a4d3dc