1231683 - Android mach commands do not offer to start an emulator if a device is connected but not usable

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

$ adb devices
016e01dbcd98f851  no permissions
$ ./mach install
 0:00.22 /usr/bin/make -C . -j8 -s -w install
 0:00.30 make: Entering directory `/home/gbrown/objdirs/droid'
 0:00.30 No devices are connected.  Connect a device or start an emulator.
 0:00.30 make: *** [install] Error 1
 0:00.30 make: Leaving directory `/home/gbrown/objdirs/droid'


This may be okay, but I wonder if it could be more awesome. Improvements here might also help handle other device oddities better.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: disregard devices not recognized by 'adb devices'

This feels more awesome:

$ adb devices
016e01dbcd98f851  no permissions
$ ./mach install
No Android devices connected. Start an emulator? (Y/n) y
Starting emulator running Android 4.3...
 2:16.70 /usr/bin/make -C . -j8 -s -w install
 2:16.80 make: Entering directory `/home/gbrown/objdirs/droid'
 2:27.35 3981 KB/s (42677208 bytes in 10.468s)
 2:28.12 	pkg: /data/local/tmp/fennec-45.0a1.en-US.android-arm.apk
 2:41.48 Success
 2:41.86 make: Leaving directory `/home/gbrown/objdirs/droid'

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8698038 [details] [diff] [review]
disregard devices not recognized by 'adb devices'

Review of attachment 8698038 [details] [diff] [review]:
-----------------------------------------------------------------

cool!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd4bfd5bd43e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd4bfd5bd43e