1231704 - Enable autolander for Loop on github

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

Now loop is in its own github repository, we'd like to enable the autolander that gaia uses.

https://github.com/mozilla/loop
https://github.com/mozilla/autolander

This should allow pull requests to be automatically attached to bugs, and for auto-landing to happen after it has been reviewed.

Comment 1

[Mark Banner (:standard8)]

Kevin, a couple of questions:

- where does BUGZILLA_SUPPORTED_PRODUCTS need to be changed?
- As we don't use taskcluster/treeherder currently (only travis), where does that get configured

Comment 2

[Kevin Grandon :kgrandon]

(In reply to Mark Banner (:standard8) from comment #1)
> - where does BUGZILLA_SUPPORTED_PRODUCTS need to be changed?

This is an environment variable in Heroku. I'm not sure I have access still, but we can find someone to enable this for your product as well.

> - As we don't use taskcluster/treeherder currently (only travis), where does
> that get configured

This is fine - it will look for the taskcluster configuration file and if none is found it will just land the patches once they have an R+ and the `autoland` keyword is added to the bug.

Comment 3

[Kevin Grandon :kgrandon]

Mark - are you guys currently using the "suggested reviewer" feature at all? Can you please audit the list and make sure that all of them are peers/owners of some part of Hello code?

If we don't have any suggested reviewers, we'll need to add some.

Comment 4

[Mark Banner (:standard8)]

(In reply to Kevin Grandon :kgrandon from comment #3)
> Mark - are you guys currently using the "suggested reviewer" feature at all?
> Can you please audit the list and make sure that all of them are
> peers/owners of some part of Hello code?

Yes we're using them and the lists are fine.

Comment 5

[Kevin Grandon :kgrandon]

Sounds good. Adding a needinfo on myself to look into this further, likely next week.

Comment 6

[Kevin Grandon :kgrandon]

Partial update here: The autolander user and webhook have been added to the repo, so autolander is now able to make attachments to bugs for pull requests opened in the hello repo. You can see an example of this in bug 1233741.

Unfortunately the `autoland` keyword is not fully hooked up yet, I believe I need to re-deploy the autolander product and was running into some heroku environment issues with having to upgrade cedar. I will file a bug for this and track it separately.

Comment 7

[Kevin Grandon :kgrandon]

Ok, I was able to restart the heroku thing and I think this should actually just work, neat.

I would like to try this with one end-to-end patch, so I'll look at updating the readme or something simple.