1231785 - [experiment] TP UI Tour does not allow linking to page 2

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect, P1)

Description

[Javaun Moradi [:javaun]]

In production, the TP UI tour cannot go directly to step 2.

https://www.mozilla.org/en-US/firefox/45.0a1/tracking-protection/start/?step=2

We're not using this now, but in the near future we'll have a second pathway in to the TP tour -- a doorhanger -- that goes directly to step 2.

Comment 1

[Alex Gibson [:agibson]]

We currently only handle step3 conditionally on page load, since going straight to step2 was surplus to requirement for the original tour. We should be able to change this easily enough if required.

Comment 2

[:Paolo Amadini]

Is there a way I could test this locally with a version that supports linking to step 2?

Apparently the change I need to make is simple:

https://github.com/mozilla/bedrock/blob/master/media/js/firefox/tracking-protection-tour.js#L281

I'll need this for testing the new front-end entry point in bug 1231757.

Comment 3

[Alex Gibson [:agibson]]

You can either install bedrock locally and test, or you can wait until I can take this bug and put it up on a demo server. It shouldn't take long, but I'm on PTO until Friday.

Comment 4

[Alex Gibson [:agibson]]

I've pushed a patch up to demo2:

https://www-demo2.allizom.org/en-US/firefox/45.0a1/tracking-protection/start/

Please note for the tour to work on the demo2 server, you will need to whitelist https://www-demo2.allizom.org for UITour:

http://bedrock.readthedocs.org/en/latest/uitour.html#local-development

If you also need to set the TP tour button URL see:

http://bedrock.readthedocs.org/en/latest/uitour.html#tracking-protection-uitour

Paolo, please confirm that this patch does what you need, and I will get it reviewed and merged/pushed to production. Thanks

Comment 5

[:Paolo Amadini]

Thanks for the quick update and the setup information! Works perfectly.

Just a heads up that we may need to use a version of the tour that closes the tab at the end instead of restarting it. Not sure whether there is a UITour API to do that, though. We'll file new bugs anyways.

Comment 6

[Alex Gibson [:agibson]]

(In reply to :Paolo Amadini from comment #5)
> Thanks for the quick update and the setup information! Works perfectly.
> 
> Just a heads up that we may need to use a version of the tour that closes
> the tab at the end instead of restarting it. Not sure whether there is a
> UITour API to do that, though. We'll file new bugs anyways.

Great, thanks. I'll open a PR for review.

Fwiw, I don't think we currently have the ability to close a tab via clicking an element on the page. There's no UITour function to do so as it stands, and window.close() only works for windows that are opened via a script e.g. window.open().

Comment 7

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a58828f365289c939257c8fc2dbbf1f55b5acb6e
[fix bug 1231785] TP UI Tour does not allow linking to step 2

https://github.com/mozilla/bedrock/commit/6832f36ad00656da06fb6d23824532d100fc4415
Merge pull request #3676 from mozilla/bug-1231785-tp-tour-link-step-2

[fix bug 1231785] TP UI Tour does not allow linking to step 2

Comment 9

[Paul Silaghi, QA [:pauly]]

(In reply to Javaun Moradi [:javaun] from comment #0)
> In production, the TP UI tour cannot go directly to step 2.> 
> https://www.mozilla.org/en-US/firefox/45.0a1/tracking-protection/start/
> ?step=2
How exactly can this be tested? While trying to reproduce, Step 2 was displayed fine by simply opening the above link in Nightly 2015-12-10.

Comment 10

[Alex Gibson [:agibson]]

(In reply to Paul Silaghi, QA [:pauly] from comment #9)
> (In reply to Javaun Moradi [:javaun] from comment #0)
> > In production, the TP UI tour cannot go directly to step 2.> 
> > https://www.mozilla.org/en-US/firefox/45.0a1/tracking-protection/start/
> > ?step=2
> How exactly can this be tested? While trying to reproduce, Step 2 was
> displayed fine by simply opening the above link in Nightly 2015-12-10.

This bug has already been fixed and deployed to production. Looks like you have just verified it is working? :)

Comment 11

[Paul Silaghi, QA [:pauly]]

I guess so. Thanks.