1231804 - In conversation window remove the gear button and put audio/face mute buttons at the center

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Comment 1

[Manuel Casas Barrado [:mancas]]

Attachment: Github PR

Can you review this patch Mike?

Thanks!

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: Screen Shot 2015-12-16 at 11.06.10.png

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: Link generator version

Comment 4

[Sevaan Franks [:sevaan]]

Comment on attachment 8698888 [details]
Screen Shot 2015-12-16 at 11.06.10.png

I think the Link Clicker can be left as is with the buttons left-aligned with the exit button. We're going to be changing this whole layout soon anyway.

Comment 5

[Mark Banner (:standard8)]

(In reply to Sevaan Franks [:sevaan] from comment #4)
> I think the Link Clicker can be left as is with the buttons left-aligned
> with the exit button. We're going to be changing this whole layout soon
> anyway.

Ok, so a different way of wording this, is that for the larger displays, we should have them left-aligned, and for the narrow width conversation window, they should be middle.

That should cover standalone & desktop in different layout modes nicely ;-)

Comment 6

[Manuel Casas Barrado [:mancas]]

Attachment: Standalone version

Buttons are now, left aligned using high resolutions (more than 350px) and center aligned in the conversation window.

Comment 7

[Mark Banner (:standard8)]

I rebased this and fixed the eslint error on behalf of Manu:

https://github.com/mozilla/loop/commit/c6624313e0b5804f3cb71f317450fec994e70766

Comment 8

[Paul Silaghi, QA [:pauly]]

FF 46.0a1 (2016-01-19) Win 7.
The buttons are no longer centered after detaching the conversation window. Reducing then the window to minimum, makes the buttons centered again.
Is this expected?

Comment 9

[Mark Banner (:standard8)]

(In reply to Paul Silaghi, QA [:pauly] from comment #8)
> FF 46.0a1 (2016-01-19) Win 7.
> The buttons are no longer centered after detaching the conversation window.
> Reducing then the window to minimum, makes the buttons centered again.
> Is this expected?

They are adapting to the different layouts of the display, which is currently based on width. Pau/Sevaan are probably better folks to check the behaviour with.

Comment 10

[Sevaan Franks [:sevaan]]

> They are adapting to the different layouts of the display, which is
> currently based on width. Pau/Sevaan are probably better folks to check the
> behaviour with.

This seems to be the case. Is it possible to make the window pop slightly larger or smaller? If the former, the layout looks correct. If the latter, we can keep the center button. For me, at least, it is popping at a responsive breakpoint just before the center aligned icons, so it looks awkward. Another solution could be to change the breakpoint so the icons center earlier when sizing a window smaller.

Comment 11

[Mark Banner (:standard8)]

(In reply to Sevaan Franks [:sevaan] from comment #10)
> > They are adapting to the different layouts of the display, which is
> > currently based on width. Pau/Sevaan are probably better folks to check the
> > behaviour with.
> 
> This seems to be the case. Is it possible to make the window pop slightly
> larger or smaller? If the former, the layout looks correct. If the latter,
> we can keep the center button. For me, at least, it is popping at a
> responsive breakpoint just before the center aligned icons, so it looks
> awkward. Another solution could be to change the breakpoint so the icons
> center earlier when sizing a window smaller.

The popped-out window remembers the size you last set it to. So we'd be optimising for the default profile only...

Comment 12

[Sevaan Franks [:sevaan]]

I think that's fair to set. A user needs to pop the window out a first time, so we might as well make that first time look its best. I think setting the window size to match the conversation window size so the icons are center aligned is probably best.

Comment 13

[Mark Banner (:standard8)]

(In reply to Sevaan Franks [:sevaan] from comment #12)
> I think that's fair to set. A user needs to pop the window out a first time,
> so we might as well make that first time look its best. I think setting the
> window size to match the conversation window size so the icons are center
> aligned is probably best.

Ok, can you check with a fresh profile, and then file a bug on this please?

Comment 14

[Sevaan Franks [:sevaan]]

(In reply to Mark Banner (:standard8) from comment #13)
> (In reply to Sevaan Franks [:sevaan] from comment #12)
> > I think that's fair to set. A user needs to pop the window out a first time,
> > so we might as well make that first time look its best. I think setting the
> > window size to match the conversation window size so the icons are center
> > aligned is probably best.
> 
> Ok, can you check with a fresh profile, and then file a bug on this please?

Tested on a fresh profile and filed Bug 1242508. I don't think we need to set the size of the window. Rather, we need to fix the formatting of the middle-stage responsive break.

Comment 15

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 46, considering the follow-up bug 1242508.