1231806 - testing/mochitest/ code should follow the flake8 convention

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Run on the Firefox source code, the following line shows a bunch of warnings. Nothing critical but it would be nice to remove them:
flake8 --max-line-length=4000 testing/mochitest/|grep -v pywebsocket

pywebsocket is a third party library, we should not updated it.

Comment 1

[simon]

I would like to take this bug.

Comment 2

[simon]

Attachment: Fix syntax error reported by flake8

Comment 3

[simon]

Attachment: Remove useless import reported by flake8

Comment 4

[simon]

Attachment: Fix visual indentation reported by flake8

Comment 5

[simon]

Attachment: Remove trailing spaces reported by flake8

Comment 6

[simon]

Attachment: Fix blanklines issues reported by flake8

Comment 7

[simon]

Attachment: Remove useless semi-colon reported by flake8

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 8702262 [details] [diff] [review]
Fix syntax error reported by flake8

Review of attachment 8702262 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patches! FYI, in the future for simple cleanup like this, feel free to submit these all as one large patch.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Ted, someone asked me in the past to do a patch per kind of error. Do we have a policy here?
(FWIW, I agree with you)

Requesting the checkin on Simon's behalf.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d35b3ef1bdb6
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f187e5d5a53
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a8c0bac7bd2
https://hg.mozilla.org/integration/mozilla-inbound/rev/64191519db53
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6fe454687d5
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8a7896caec0

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d35b3ef1bdb6
https://hg.mozilla.org/mozilla-central/rev/6f187e5d5a53
https://hg.mozilla.org/mozilla-central/rev/4a8c0bac7bd2
https://hg.mozilla.org/mozilla-central/rev/64191519db53
https://hg.mozilla.org/mozilla-central/rev/f6fe454687d5
https://hg.mozilla.org/mozilla-central/rev/f8a7896caec0

Comment 12

[(not currently active) Ted Mielczarek]

(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Ted, someone asked me in the past to do a patch per kind of error. Do we
> have a policy here?
> (FWIW, I agree with you)

In general I tend to just tell people to use their best judgement and try to do what results in the least amount of work for both the patch author and the reviewer.