Closed Bug 1231806 Opened 5 years ago Closed 5 years ago

testing/mochitest/ code should follow the flake8 convention

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: Sylvestre, Assigned: simon)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Run on the Firefox source code, the following line shows a bunch of warnings. Nothing critical but it would be nice to remove them:
flake8 --max-line-length=4000 testing/mochitest/|grep -v pywebsocket

pywebsocket is a third party library, we should not updated it.
Depends on: 1231810
No longer depends on: 1231810
Blocks: flake8
I would like to take this bug.
Assignee: nobody → simon
QA Contact: ted
Mentor: jmaher
QA Contact: ted → jmaher
Attachment #8702262 - Flags: review?(ted)
Mentor: jmaher
QA Contact: jmaher → ted
Attachment #8702263 - Flags: review?(ted)
Attachment #8702264 - Flags: review?(ted)
Attachment #8702265 - Flags: review?(ted)
Attachment #8702266 - Flags: review?(ted)
Attachment #8702267 - Flags: review?(ted)
Attachment #8702267 - Flags: review?(ted) → review+
Attachment #8702266 - Flags: review?(ted) → review+
Attachment #8702265 - Flags: review?(ted) → review+
Attachment #8702264 - Flags: review?(ted) → review+
Attachment #8702263 - Flags: review?(ted) → review+
Comment on attachment 8702262 [details] [diff] [review]
Fix syntax error reported by flake8

Review of attachment 8702262 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patches! FYI, in the future for simple cleanup like this, feel free to submit these all as one large patch.
Attachment #8702262 - Flags: review?(ted) → review+
Ted, someone asked me in the past to do a patch per kind of error. Do we have a policy here?
(FWIW, I agree with you)

Requesting the checkin on Simon's behalf.
Keywords: checkin-needed
(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Ted, someone asked me in the past to do a patch per kind of error. Do we
> have a policy here?
> (FWIW, I agree with you)

In general I tend to just tell people to use their best judgement and try to do what results in the least amount of work for both the patch author and the reviewer.
You need to log in before you can comment on or make changes to this bug.