testing/mochitest/ code should follow the flake8 convention

RESOLVED FIXED in Firefox 46

Status

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: sylvestre, Assigned: simon)

Tracking

(Blocks 1 bug)

unspecified
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(6 attachments)

Reporter

Description

4 years ago
Run on the Firefox source code, the following line shows a bunch of warnings. Nothing critical but it would be nice to remove them:
flake8 --max-line-length=4000 testing/mochitest/|grep -v pywebsocket

pywebsocket is a third party library, we should not updated it.
Reporter

Updated

4 years ago
Depends on: 1231810
Reporter

Updated

4 years ago
No longer depends on: 1231810
Reporter

Updated

4 years ago
Blocks: flake8
Assignee

Comment 1

4 years ago
I would like to take this bug.
Reporter

Updated

4 years ago
Assignee: nobody → simon
Assignee

Comment 2

4 years ago
Assignee

Updated

4 years ago
QA Contact: ted
Assignee

Updated

4 years ago
Mentor: jmaher
QA Contact: ted → jmaher
Assignee

Updated

4 years ago
Attachment #8702262 - Flags: review?(ted)
Assignee

Updated

4 years ago
Mentor: jmaher
QA Contact: jmaher → ted
Assignee

Updated

4 years ago
Attachment #8702263 - Flags: review?(ted)
Assignee

Updated

4 years ago
Attachment #8702264 - Flags: review?(ted)
Assignee

Updated

4 years ago
Attachment #8702265 - Flags: review?(ted)
Assignee

Updated

4 years ago
Attachment #8702266 - Flags: review?(ted)
Assignee

Updated

4 years ago
Attachment #8702267 - Flags: review?(ted)
Attachment #8702267 - Flags: review?(ted) → review+
Attachment #8702266 - Flags: review?(ted) → review+
Attachment #8702265 - Flags: review?(ted) → review+
Attachment #8702264 - Flags: review?(ted) → review+
Attachment #8702263 - Flags: review?(ted) → review+
Comment on attachment 8702262 [details] [diff] [review]
Fix syntax error reported by flake8

Review of attachment 8702262 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patches! FYI, in the future for simple cleanup like this, feel free to submit these all as one large patch.
Attachment #8702262 - Flags: review?(ted) → review+
Reporter

Comment 9

3 years ago
Ted, someone asked me in the past to do a patch per kind of error. Do we have a policy here?
(FWIW, I agree with you)

Requesting the checkin on Simon's behalf.
Keywords: checkin-needed
(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Ted, someone asked me in the past to do a patch per kind of error. Do we
> have a policy here?
> (FWIW, I agree with you)

In general I tend to just tell people to use their best judgement and try to do what results in the least amount of work for both the patch author and the reviewer.
Comment hidden (spam)
You need to log in before you can comment on or make changes to this bug.